From 981f3a9068bbd8fe9a868e2de00dccf0470b8ad9 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 18 Mar 2016 15:56:12 -0700
Subject: [PATCH] When marking up Phurl URLs for mail, use absolute URLs

Summary: Fixes T10625.

Test Plan: Faked this locallly and it looked OK, I'll check the mail in production. :3333

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10625

Differential Revision: https://secure.phabricator.com/D15497
---
 .../PhabricatorPhurlLinkRemarkupRule.php      | 55 ++++++++++---------
 1 file changed, 28 insertions(+), 27 deletions(-)

diff --git a/src/applications/phurl/remarkup/PhabricatorPhurlLinkRemarkupRule.php b/src/applications/phurl/remarkup/PhabricatorPhurlLinkRemarkupRule.php
index aca7c14dc7..4ef59b300c 100644
--- a/src/applications/phurl/remarkup/PhabricatorPhurlLinkRemarkupRule.php
+++ b/src/applications/phurl/remarkup/PhabricatorPhurlLinkRemarkupRule.php
@@ -18,7 +18,9 @@ final class PhabricatorPhurlLinkRemarkupRule extends PhutilRemarkupRule {
   public function markupLink(array $matches) {
     $engine = $this->getEngine();
     $viewer = $engine->getConfig('viewer');
+
     $text_mode = $engine->isTextMode();
+    $html_mode = $engine->isHTMLMailMode();
 
     if (!$this->isFlatText($matches[0])) {
       return $matches[0];
@@ -28,46 +30,45 @@ final class PhabricatorPhurlLinkRemarkupRule extends PhutilRemarkupRule {
     $monogram = null;
     $is_monogram = '/^U(?P<id>[1-9]\d*)/';
 
+    $query = id(new PhabricatorPhurlURLQuery())
+      ->setViewer($viewer);
+
     if (preg_match($is_monogram, $ref, $monogram)) {
-      $phurls = id(new PhabricatorPhurlURLQuery())
-        ->setViewer($viewer)
-        ->withIDs(array($monogram[1]))
-        ->execute();
+      $query->withIDs(array($monogram[1]));
     } else if (ctype_digit($ref)) {
-      $phurls = id(new PhabricatorPhurlURLQuery())
-        ->setViewer($viewer)
-        ->withIDs(array($ref))
-        ->execute();
+      $query->withIDs(array($ref));
     } else {
-      $phurls = id(new PhabricatorPhurlURLQuery())
-        ->setViewer($viewer)
-        ->withAliases(array($ref))
-        ->execute();
+      $query->withAliases(array($ref));
     }
 
-    $phurl = head($phurls);
+    $phurl = $query->executeOne();
+    if (!$phurl) {
+      return $matches[0];
+    }
 
-    if ($phurl) {
-      if ($text_mode) {
-        return $phurl->getDisplayName().
-          ' <'.
-          $phurl->getRedirectURI().
-          '>';
-      }
+    $uri = $phurl->getRedirectURI();
+    $name = $phurl->getDisplayName();
 
+    if ($text_mode || $html_mode) {
+      $uri = PhabricatorEnv::getProductionURI($uri);
+    }
+
+    if ($text_mode) {
+      return pht(
+        '%s <%s>',
+        $name,
+        $uri);
+    } else {
       $link = phutil_tag(
         'a',
         array(
-          'href' => $phurl->getRedirectURI(),
+          'href' => $uri,
           'target' => '_blank',
         ),
-        $phurl->getDisplayName());
-
-      return $this->getEngine()->storeText($link);
-    } else {
-      return $matches[0];
+        $name);
     }
+
+    return $this->getEngine()->storeText($link);
   }
 
-
 }