revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00
Code Issues Releases Wiki Activity

Fix a tokenizer issue in a rare edge case

Browse source 
Summary:
Ref T7689. We may not propgate the viewer down to the controls in some rendering pathways. An example is "Create Task..." on workboard columns.

Instead, move the propagation a little deeper.

Test Plan: "Create Task..." on a workboard column.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7689

Differential Revision: https://secure.phabricator.com/D12250
This commit is contained in:
epriestley 2015-04-01 12:41:23 -07:00
parent eb81fd1562
commit 983c6f9d4b
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/view/form/AphrontFormView.php
View file

@ -92,6 +92,10 @@ final class AphrontFormView extends AphrontView {
} }
public function buildLayoutView() { public function buildLayoutView() {
foreach ($this->controls as $control) {
$control->setUser($this->getUser());
}
return id(new PHUIFormLayoutView()) return id(new PHUIFormLayoutView())
->setFullWidth($this->getFullWidth()) ->setFullWidth($this->getFullWidth())
->appendChild($this->renderDataInputs()) ->appendChild($this->renderDataInputs())
@ -118,10 +122,6 @@ final class AphrontFormView extends AphrontView {
public function render() { public function render() {
require_celerity_resource('phui-form-view-css'); require_celerity_resource('phui-form-view-css');
foreach ($this->controls as $control) {
$control->setUser($this->getUser());
}
$layout = $this->buildLayoutView(); $layout = $this->buildLayoutView();
if (!$this->user) { if (!$this->user) {