revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 16:22:43 +01:00
Code Issues Releases Wiki Activity

Add a bit of test coverage for bulky vs compact edge data representations

Browse source 
Summary: Depends on D18948. Ref T13051. The actual logic ended up so simple that this doesn't really feel terribly valuable, but maybe it'll catch something later on.

Test Plan: Ran test.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13051

Differential Revision: https://secure.phabricator.com/D18949
This commit is contained in:
epriestley 2018-01-27 07:30:26 -08:00
parent 6d2d1d3a97
commit 98402b885b
2 changed files with 160 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/__phutil_library_map__.php
View file

@ -2748,6 +2748,7 @@ phutil_register_library_map(array(
'PhabricatorDraftInterface' => 'applications/transactions/draft/PhabricatorDraftInterface.php',
'PhabricatorDrydockApplication' => 'applications/drydock/application/PhabricatorDrydockApplication.php',
'PhabricatorEdgeChangeRecord' => 'infrastructure/edges/util/PhabricatorEdgeChangeRecord.php',
'PhabricatorEdgeChangeRecordTestCase' => 'infrastructure/edges/__tests__/PhabricatorEdgeChangeRecordTestCase.php',
'PhabricatorEdgeConfig' => 'infrastructure/edges/constants/PhabricatorEdgeConfig.php',
'PhabricatorEdgeConstants' => 'infrastructure/edges/constants/PhabricatorEdgeConstants.php',
'PhabricatorEdgeCycleException' => 'infrastructure/edges/exception/PhabricatorEdgeCycleException.php',
@ -8173,6 +8174,7 @@ phutil_register_library_map(array(
'PhabricatorDraftEngine' => 'Phobject',
'PhabricatorDrydockApplication' => 'PhabricatorApplication',
'PhabricatorEdgeChangeRecord' => 'Phobject',
'PhabricatorEdgeChangeRecordTestCase' => 'PhabricatorTestCase',
'PhabricatorEdgeConfig' => 'PhabricatorEdgeConstants',
'PhabricatorEdgeConstants' => 'Phobject',
'PhabricatorEdgeCycleException' => 'Exception',

158
src/infrastructure/edges/__tests__/PhabricatorEdgeChangeRecordTestCase.php Normal file
View file

@ -0,0 +1,158 @@
<?php
final class PhabricatorEdgeChangeRecordTestCase extends PhabricatorTestCase {
public function testEdgeStorageFormats() {
$old_bulky = phutil_json_decode(<<<EOJSON
{
"PHID-PROJ-5r2ed5v27xrgltvou5or" : {
"dataID" : null,
"dateCreated" : "1449170683",
"dst" : "PHID-PROJ-5r2ed5v27xrgltvou5or",
"src" : "PHID-PSTE-5uj6oqv4kmhtr6ctwcq7",
"type" : "41",
"data" : [],
"seq" : "0"
},
"PHID-PROJ-wh32nih7q5scvc5lvipv" : {
"dataID" : null,
"seq" : "0",
"type" : "41",
"data" : [],
"dst" : "PHID-PROJ-wh32nih7q5scvc5lvipv",
"src" : "PHID-PSTE-5uj6oqv4kmhtr6ctwcq7",
"dateCreated" : "1449170691"
},
"PHID-PROJ-zfp44q7loir643b5i4v4" : {
"dataID" : null,
"type" : "41",
"data" : [],
"seq" : "0",
"dateCreated" : "1449170668",
"src" : "PHID-PSTE-5uj6oqv4kmhtr6ctwcq7",
"dst" : "PHID-PROJ-zfp44q7loir643b5i4v4"
},
"PHID-PROJ-amvkc5zw2gsy7tyvocug" : {
"dataID" : null,
"dst" : "PHID-PROJ-amvkc5zw2gsy7tyvocug",
"src" : "PHID-PSTE-5uj6oqv4kmhtr6ctwcq7",
"dateCreated" : "1448833330",
"seq" : "0",
"type" : "41",
"data" : []
},
"PHID-PROJ-3cuwfuuh4pwqyuof2hhr" : {
"dataID" : null,
"seq" : "0",
"type" : "41",
"data" : [],
"dst" : "PHID-PROJ-3cuwfuuh4pwqyuof2hhr",
"src" : "PHID-PSTE-5uj6oqv4kmhtr6ctwcq7",
"dateCreated" : "1448899367"
},
"PHID-PROJ-okljqs7prifhajtvia3t" : {
"dataID" : null,
"seq" : "0",
"data" : [],
"type" : "41",
"dst" : "PHID-PROJ-okljqs7prifhajtvia3t",
"src" : "PHID-PSTE-5uj6oqv4kmhtr6ctwcq7",
"dateCreated" : "1448902756"
}
}
EOJSON
);
$new_bulky = phutil_json_decode(<<<EOJSON
{
"PHID-PROJ-5r2ed5v27xrgltvou5or" : {
"dataID" : null,
"dateCreated" : "1449170683",
"dst" : "PHID-PROJ-5r2ed5v27xrgltvou5or",
"src" : "PHID-PSTE-5uj6oqv4kmhtr6ctwcq7",
"type" : "41",
"data" : [],
"seq" : "0"
},
"PHID-PROJ-wh32nih7q5scvc5lvipv" : {
"dataID" : null,
"seq" : "0",
"type" : "41",
"data" : [],
"dst" : "PHID-PROJ-wh32nih7q5scvc5lvipv",
"src" : "PHID-PSTE-5uj6oqv4kmhtr6ctwcq7",
"dateCreated" : "1449170691"
},
"PHID-PROJ-zfp44q7loir643b5i4v4" : {
"dataID" : null,
"type" : "41",
"data" : [],
"seq" : "0",
"dateCreated" : "1449170668",
"src" : "PHID-PSTE-5uj6oqv4kmhtr6ctwcq7",
"dst" : "PHID-PROJ-zfp44q7loir643b5i4v4"
},
"PHID-PROJ-amvkc5zw2gsy7tyvocug" : {
"dataID" : null,
"dst" : "PHID-PROJ-amvkc5zw2gsy7tyvocug",
"src" : "PHID-PSTE-5uj6oqv4kmhtr6ctwcq7",
"dateCreated" : "1448833330",
"seq" : "0",
"type" : "41",
"data" : []
},
"PHID-PROJ-3cuwfuuh4pwqyuof2hhr" : {
"dataID" : null,
"seq" : "0",
"type" : "41",
"data" : [],
"dst" : "PHID-PROJ-3cuwfuuh4pwqyuof2hhr",
"src" : "PHID-PSTE-5uj6oqv4kmhtr6ctwcq7",
"dateCreated" : "1448899367"
},
"PHID-PROJ-zzzzqs7prifhajtvia3t" : {
"dataID" : null,
"seq" : "0",
"data" : [],
"type" : "41",
"dst" : "PHID-PROJ-zzzzqs7prifhajtvia3t",
"src" : "PHID-PSTE-5uj6oqv4kmhtr6ctwcq7",
"dateCreated" : "1448902756"
}
}
EOJSON
);
$old_slim = array(
'PHID-PROJ-okljqs7prifhajtvia3t',
);
$new_slim = array(
'PHID-PROJ-zzzzqs7prifhajtvia3t',
);
$bulky_xaction = new ManiphestTransaction();
$bulky_xaction->setOldValue($old_bulky);
$bulky_xaction->setNewValue($new_bulky);
$slim_xaction = new ManiphestTransaction();
$slim_xaction->setOldValue($old_slim);
$slim_xaction->setNewValue($new_slim);
$bulky_record = PhabricatorEdgeChangeRecord::newFromTransaction(
$bulky_xaction);
$slim_record = PhabricatorEdgeChangeRecord::newFromTransaction(
$slim_xaction);
$this->assertEqual(
$bulky_record->getAddedPHIDs(),
$slim_record->getAddedPHIDs());
$this->assertEqual(
$bulky_record->getRemovedPHIDs(),
$slim_record->getRemovedPHIDs());
}
}