From 98884f758a29ae5544f36940c86b20cf9455f202 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Thu, 16 May 2024 13:02:58 +0200 Subject: [PATCH] Fix call to non-existing newIcons() in PhabricatorIconSet Summary: `PhabricatorIconSet::getIcons()` calls `$this->newIcons()` which is undefined. As all six child classes which extend `PhabricatorIconSet` implement `newIcons()`, declare an abstract function in their parent class. Test Plan: Carefully read the code. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25647 --- src/applications/files/iconset/PhabricatorIconSet.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/applications/files/iconset/PhabricatorIconSet.php b/src/applications/files/iconset/PhabricatorIconSet.php index baf5422375..c31c3e11fc 100644 --- a/src/applications/files/iconset/PhabricatorIconSet.php +++ b/src/applications/files/iconset/PhabricatorIconSet.php @@ -3,6 +3,8 @@ abstract class PhabricatorIconSet extends Phobject { + abstract protected function newIcons(); + final public function getIconSetKey() { return $this->getPhobjectClassConstant('ICONSETKEY'); }