From 98c4cdc5bebf51c67bfbdc87532d2e1e679b8524 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 23 Jan 2019 14:32:00 -0800 Subject: [PATCH] Make the "PHP 7" setup warning more explicit about what it means Summary: See . Test Plan: o~o Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D20027 --- .../PhabricatorPHPPreflightSetupCheck.php | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php b/src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php index 7c9653f4ff..30c6036c8f 100644 --- a/src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php +++ b/src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php @@ -11,16 +11,23 @@ final class PhabricatorPHPPreflightSetupCheck extends PhabricatorSetupCheck { } protected function executeChecks() { - if (version_compare(phpversion(), 7, '>=') && - version_compare(phpversion(), 7.1, '<')) { + $version = phpversion(); + if (version_compare($version, 7, '>=') && + version_compare($version, 7.1, '<')) { $message = pht( - 'This version of Phabricator does not support PHP 7.0. You '. - 'are running PHP %s. Upgrade to PHP 7.1 or newer.', - phpversion()); + 'You are running PHP version %s. Phabricator does not support PHP '. + 'versions between 7.0 and 7.1.'. + "\n\n". + 'PHP removed signal handling features that Phabricator requires in '. + 'PHP 7.0, and did not restore them until PHP 7.1.'. + "\n\n". + 'Upgrade to PHP 7.1 or newer (recommended) or downgrade to an older '. + 'version of PHP 5 (discouraged).', + $version); $this->newIssue('php.version7') ->setIsFatal(true) - ->setName(pht('PHP 7.0 Not Supported')) + ->setName(pht('PHP 7.0-7.1 Not Supported')) ->setMessage($message) ->addLink( 'https://phurl.io/u/php7',