From 991368128e4dc7819f0772f25f7cca4a6a428c41 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 13 Feb 2019 08:56:54 -0800 Subject: [PATCH] Bump the markup cache version for URI changes Summary: Ref T13250. Ref T13249. Some remarkup rules, including `{image ...}` and `{meme ...}`, may cache URIs as objects because the remarkup cache is `serialize()`-based. URI objects with `query` cached as a key-value map are no longer valid and can raise `__toString()` fatals. Bump the cache version to purge them out of the cache. Test Plan: See PHI1074. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13250, T13249 Differential Revision: https://secure.phabricator.com/D20160 --- src/infrastructure/markup/PhabricatorMarkupEngine.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/infrastructure/markup/PhabricatorMarkupEngine.php b/src/infrastructure/markup/PhabricatorMarkupEngine.php index 868bbc5676..3a63cb97a6 100644 --- a/src/infrastructure/markup/PhabricatorMarkupEngine.php +++ b/src/infrastructure/markup/PhabricatorMarkupEngine.php @@ -42,7 +42,7 @@ final class PhabricatorMarkupEngine extends Phobject { private $objects = array(); private $viewer; private $contextObject; - private $version = 17; + private $version = 18; private $engineCaches = array(); private $auxiliaryConfig = array();