From 991fee211895bfb8d0c044cf957ebddd5c12cb51 Mon Sep 17 00:00:00 2001
From: vrana <jakubv@fb.com>
Date: Sat, 25 Feb 2012 23:21:05 -0800
Subject: [PATCH] Use wide links instead of fake cursor in Differential

Summary:
Current approach has several problems:

- if there is no link in the cell then it still shows a link cursor
- if there is a link then it is clickable only on the text

Test Plan:
Display file in Differential, hover over cell with link.
Repeat for Paste.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1701
---
 src/__celerity_resource_map__.php                      |  2 +-
 .../controller/file/DiffusionBrowseFileController.php  |  1 -
 .../css/application/diffusion/diffusion-source.css     | 10 ++++------
 3 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php
index a2bca84377..ecc9614cfc 100644
--- a/src/__celerity_resource_map__.php
+++ b/src/__celerity_resource_map__.php
@@ -267,7 +267,7 @@ celerity_register_resource_map(array(
   ),
   'diffusion-source-css' =>
   array(
-    'uri' => '/res/db4566b6/rsrc/css/application/diffusion/diffusion-source.css',
+    'uri' => '/res/a8d2834e/rsrc/css/application/diffusion/diffusion-source.css',
     'type' => 'css',
     'requires' =>
     array(
diff --git a/src/applications/diffusion/controller/file/DiffusionBrowseFileController.php b/src/applications/diffusion/controller/file/DiffusionBrowseFileController.php
index bd1bf2e35e..e5bffdf987 100644
--- a/src/applications/diffusion/controller/file/DiffusionBrowseFileController.php
+++ b/src/applications/diffusion/controller/file/DiffusionBrowseFileController.php
@@ -405,7 +405,6 @@ class DiffusionBrowseFileController extends DiffusionController {
       $l = phutil_render_tag(
         'a',
         array(
-          'class' => 'diffusion-line-link',
           'href' => $uri_path.';'.$uri_rev.'$'.$n.$uri_view,
         ),
         $n);
diff --git a/webroot/rsrc/css/application/diffusion/diffusion-source.css b/webroot/rsrc/css/application/diffusion/diffusion-source.css
index 6bdf0f5e6e..ebee732845 100644
--- a/webroot/rsrc/css/application/diffusion/diffusion-source.css
+++ b/webroot/rsrc/css/application/diffusion/diffusion-source.css
@@ -17,7 +17,6 @@
   vertical-align:     top;
   background:         #eeeeee;
   color:              #888888;
-  cursor:             pointer;
   border-style:       solid;
   border-width:       0px 1px;
   border-color:       #eeeeee #999999 #eeeeee #dddddd;
@@ -27,6 +26,10 @@
   overflow:           hidden;
 }
 
+.diffusion-source th a {
+  display: block;
+}
+
 .diffusion-source td {
   letter-spacing:     0.0083334px;
   vertical-align:     top;
@@ -37,11 +40,6 @@
   overflow:           hidden;
 }
 
-.diffusion-line-link {
-  /* Give the user a larger click target. */
-  display: block;
-}
-
 .diffusion-browse-type-form {
   float: right;
 }