Use icons with Config Options page

Summary: This sets an icon for each config, makes it easier to scan.

Test Plan:
Reload Config page, see all new icons

{F281089}

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11619

src/applications/config/controller/PhabricatorConfigListController.php

@@ -47,7 +47,8 @@ final class PhabricatorConfigListController
       $item = id(new PHUIObjectItemView())
         ->setHeader($group->getName())
         ->setHref('/config/group/'.$group->getKey().'/')
-        ->addAttribute($group->getDescription());
+        ->addAttribute($group->getDescription())
+        ->setFontIcon($group->getFontIcon());
       $list->addItem($item);
     }
 

src/applications/config/option/PhabricatorAWSConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorAWSConfigOptions
     return pht('Configure integration with AWS (EC2, SES, S3, etc).');
   }
 
+  public function getFontIcon() {
+    return 'fa-server';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('amazon-ses.access-key', 'string', null)

src/applications/config/option/PhabricatorAccessLogConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorAccessLogConfigOptions
     return pht('Configure the access logs, which log HTTP/SSH requests.');
   }
 
+  public function getFontIcon() {
+    return 'fa-list';
+  }
+
   public function getOptions() {
     $common_map = array(
       'C' => pht('The controller or workflow which handled the request.'),

src/applications/config/option/PhabricatorApplicationConfigOptions.php

@@ -6,6 +6,10 @@ abstract class PhabricatorApplicationConfigOptions extends Phobject {
   abstract public function getDescription();
   abstract public function getOptions();
 
+  public function getFontIcon() {
+    return 'fa-sliders';
+  }
+
   public function validateOption(PhabricatorConfigOption $option, $value) {
     if ($value === $option->getDefault()) {
       return;

src/applications/config/option/PhabricatorAuthenticationConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorAuthenticationConfigOptions
     return pht('Options relating to authentication.');
   }
 
+  public function getFontIcon() {
+    return 'fa-key';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('auth.require-email-verification', 'bool', false)

src/applications/config/option/PhabricatorClusterConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorClusterConfigOptions
     return pht('Configure Phabricator to run on a cluster of hosts.');
   }
 
+  public function getFontIcon() {
+    return 'fa-sitemap';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('cluster.addresses', 'list<string>', array())

src/applications/config/option/PhabricatorCoreConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorCoreConfigOptions
     return pht('Configure core options, including URIs.');
   }
 
+  public function getFontIcon() {
+    return 'fa-bullseye';
+  }
+
   public function getOptions() {
     if (phutil_is_windows()) {
       $paths = array();

src/applications/config/option/PhabricatorDeveloperConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorDeveloperConfigOptions
     return pht('Options for Phabricator developers, including debugging.');
   }
 
+  public function getFontIcon() {
+    return 'fa-bug';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('darkconsole.enabled', 'bool', false)

src/applications/config/option/PhabricatorDisqusConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorDisqusConfigOptions
     return pht('Disqus authentication and integration options.');
   }
 
+  public function getFontIcon() {
+    return 'fa-comment';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('disqus.shortname', 'string', null)

src/applications/config/option/PhabricatorExtendingPhabricatorConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorExtendingPhabricatorConfigOptions
     return pht('Make Phabricator even cooler!');
   }
 
+  public function getFontIcon() {
+    return 'fa-rocket';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('load-libraries', 'list<string>', array())

src/applications/config/option/PhabricatorGarbageCollectorConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorGarbageCollectorConfigOptions
     return pht('Configure the GC for old logs, caches, etc.');
   }
 
+  public function getFontIcon() {
+    return 'fa-trash-o';
+  }
+
   public function getOptions() {
 
     $options = array(

src/applications/config/option/PhabricatorMailgunConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorMailgunConfigOptions
     return pht('Configure Mailgun integration.');
   }
 
+  public function getFontIcon() {
+    return 'fa-send-o';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('mailgun.domain', 'string', null)

src/applications/config/option/PhabricatorMetaMTAConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorMetaMTAConfigOptions
     return pht('Configure Mail.');
   }
 
+  public function getFontIcon() {
+    return 'fa-send';
+  }
+
   public function getOptions() {
     $send_as_user_desc = $this->deformat(pht(<<<EODOC
 When a user takes an action which generates an email notification (like

src/applications/config/option/PhabricatorMySQLConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorMySQLConfigOptions
     return pht('Database configuration.');
   }
 
+  public function getFontIcon() {
+    return 'fa-database';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('mysql.host', 'string', 'localhost')

src/applications/config/option/PhabricatorNotificationConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorNotificationConfigOptions
     return pht('Configure real-time notifications.');
   }
 
+  public function getFontIcon() {
+    return 'fa-bell';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('notification.enabled', 'bool', false)

src/applications/config/option/PhabricatorPHDConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorPHDConfigOptions
     return pht('Options relating to PHD (daemons).');
   }
 
+  public function getFontIcon() {
+    return 'fa-pied-piper-alt';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('phd.pid-directory', 'string', '/var/tmp/phd/pid')

src/applications/config/option/PhabricatorPHPMailerConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorPHPMailerConfigOptions
     return pht('Configure PHPMailer.');
   }
 
+  public function getFontIcon() {
+    return 'fa-send-o';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('phpmailer.mailer', 'string', 'smtp')

src/applications/config/option/PhabricatorRecaptchaConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorRecaptchaConfigOptions
     return pht('Configure Recaptcha captchas.');
   }
 
+  public function getFontIcon() {
+    return 'fa-recycle';
+  }
+
   public function getOptions() {
 
     return array(

src/applications/config/option/PhabricatorSMSConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorSMSConfigOptions
     return pht('Configure SMS.');
   }
 
+  public function getFontIcon() {
+    return 'fa-mobile';
+  }
+
   public function getOptions() {
     $adapter_description = $this->deformat(pht(<<<EODOC
 Adapter class to use to transmit SMS to an external provider. A given external

src/applications/config/option/PhabricatorSecurityConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorSecurityConfigOptions
     return pht('Security options.');
   }
 
+  public function getFontIcon() {
+    return 'fa-lock';
+  }
+
   public function getOptions() {
     $support_href = PhabricatorEnv::getDoclink('Give Feedback! Get Support!');
 

src/applications/config/option/PhabricatorSendGridConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorSendGridConfigOptions
     return pht('Configure SendGrid integration.');
   }
 
+  public function getFontIcon() {
+    return 'fa-send-o';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('sendgrid.api-user', 'string', null)

src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorSyntaxHighlightingConfigOptions
     return pht('Options relating to syntax highlighting source code.');
   }
 
+  public function getFontIcon() {
+    return 'fa-code';
+  }
+
   public function getOptions() {
 
     $caches_href = PhabricatorEnv::getDocLink('Managing Caches');

src/applications/config/option/PhabricatorTranslationsConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorTranslationsConfigOptions
     return pht('Options relating to translations.');
   }
 
+  public function getFontIcon() {
+    return 'fa-globe';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption(

src/applications/config/option/PhabricatorUIConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorUIConfigOptions
     return pht('Configure the Phabricator UI, including colors.');
   }
 
+  public function getFontIcon() {
+    return 'fa-magnet';
+  }
+
   public function getOptions() {
     $manifest = PHUIIconView::getSheetManifest('main-header');
 

src/applications/conpherence/config/ConpherenceConfigOptions.php

@@ -11,6 +11,10 @@ final class ConpherenceConfigOptions
     return pht('Configure Conpherence messaging.');
   }
 
+  public function getFontIcon() {
+    return 'fa-comments';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption(

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorDifferentialConfigOptions
     return pht('Configure Differential code review.');
   }
 
+  public function getFontIcon() {
+    return 'fa-cog';
+  }
+
   public function getOptions() {
     $custom_field_type = 'custom:PhabricatorCustomFieldConfigOptionType';
 

src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorDiffusionConfigOptions
     return pht('Configure Diffusion repository browsing.');
   }
 
+  public function getFontIcon() {
+    return 'fa-code';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption(

src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorAsanaConfigOptions
     return pht('Asana integration options.');
   }
 
+  public function getFontIcon() {
+    return 'fa-exchange';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('asana.workspace-id', 'string', null)

src/applications/feed/config/PhabricatorFeedConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorFeedConfigOptions
     return pht('Feed options.');
   }
 
+  public function getFontIcon() {
+    return 'fa-newspaper-o';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('feed.public', 'bool', false)

src/applications/files/config/PhabricatorFilesConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorFilesConfigOptions
     return pht('Configure files and file storage.');
   }
 
+  public function getFontIcon() {
+    return 'fa-file';
+  }
+
   public function getOptions() {
     $viewable_default = array(
       'image/jpeg'  => 'image/jpeg',

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorHarbormasterConfigOptions
     return pht('Configure Harbormaster build engine.');
   }
 
+  public function getFontIcon() {
+    return 'fa-ship';
+  }
+
   public function getOptions() {
     return array();
   }

src/applications/legalpad/config/PhabricatorLegalpadConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorLegalpadConfigOptions
     return pht('Configure Legalpad.');
   }
 
+  public function getFontIcon() {
+    return 'fa-gavel';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption(

src/applications/macro/config/PhabricatorMacroConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorMacroConfigOptions
     return pht('Configure Macro.');
   }
 
+  public function getFontIcon() {
+    return 'fa-file-image-o';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('metamta.macro.reply-handler-domain', 'string', null)

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorManiphestConfigOptions
     return pht('Configure Maniphest.');
   }
 
+  public function getFontIcon() {
+    return 'fa-anchor';
+  }
+
   public function getOptions() {
 
     $priority_defaults = array(

src/applications/owners/config/PhabricatorOwnersConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorOwnersConfigOptions
     return pht('Configure Owners.');
   }
 
+  public function getFontIcon() {
+    return 'fa-gift';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption(

src/applications/paste/config/PhabricatorPasteConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorPasteConfigOptions
     return pht('Configure Paste.');
   }
 
+  public function getFontIcon() {
+    return 'fa-paste';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption(

src/applications/people/config/PhabricatorUserConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorUserConfigOptions
     return pht('User profiles configuration.');
   }
 
+  public function getFontIcon() {
+    return 'fa-users';
+  }
+
   public function getOptions() {
 
     $default = array(

src/applications/phame/config/PhabricatorPhameConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorPhameConfigOptions
     return pht('Configure Phame blogs.');
   }
 
+  public function getFontIcon() {
+    return 'fa-star';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption(

src/applications/pholio/config/PhabricatorPholioConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorPholioConfigOptions
     return pht('Configure Pholio.');
   }
 
+  public function getFontIcon() {
+    return 'fa-camera-retro';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('metamta.pholio.reply-handler-domain', 'string', null)

src/applications/phrequent/config/PhabricatorPhrequentConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorPhrequentConfigOptions
     return pht('Configure Phrequent.');
   }
 
+  public function getFontIcon() {
+    return 'fa-clock-o';
+  }
+
   public function getOptions() {
     return array();
   }

src/applications/phriction/config/PhabricatorPhrictionConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorPhrictionConfigOptions
     return pht('Options related to Phriction (wiki).');
   }
 
+  public function getFontIcon() {
+    return 'fa-book';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption(

src/applications/policy/config/PhabricatorPolicyConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorPolicyConfigOptions
     return pht('Options relating to object visibility.');
   }
 
+  public function getFontIcon() {
+    return 'fa-lock';
+  }
+
   public function getOptions() {
     $policy_locked_type = 'custom:PolicyLockOptionType';
     $policy_locked_example = array(

src/applications/project/config/PhabricatorProjectConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorProjectConfigOptions
     return pht('Configure Projects.');
   }
 
+  public function getFontIcon() {
+    return 'fa-briefcase';
+  }
+
   public function getOptions() {
     $default_fields = array(
       'std:project:internal:description' => true,

src/applications/releeph/config/PhabricatorReleephApplicationConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorReleephApplicationConfigOptions
     return pht('Options for configuring Releeph, the release branch tool.');
   }
 
+  public function getFontIcon() {
+    return 'fa-flag-checkered';
+  }
+
   public function getOptions() {
     $default_fields = array(
       new ReleephSummaryFieldSpecification(),

src/applications/repository/PhabricatorRepositoryConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorRepositoryConfigOptions
     return pht('Configure repositories.');
   }
 
+  public function getFontIcon() {
+    return 'fa-hdd-o';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption('repository.default-local-path', 'string', '/var/repo/')

src/applications/search/config/PhabricatorSearchConfigOptions.php

@@ -11,6 +11,10 @@ final class PhabricatorSearchConfigOptions
     return pht('Options relating to Search.');
   }
 
+  public function getFontIcon() {
+    return 'fa-search';
+  }
+
   public function getOptions() {
     return array(
       $this->newOption(