mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-18 19:40:55 +01:00
Execute Harbormaster buildable filtering properly from HarbormasterBuildSearchEngine
Summary: Ref T11473. When running `harbormaster.build.search` with a `buildables` constraint, the constraint doesn't get passed to the Query and so currently has no effect. This piece of logic was just accidentally omitted from D16356. It is probably not used anywhere today and doesn't show up in the UI, so it's easy to overlook (I missed it in review, too). Test Plan: Ran `harbormaster.build.search` with a `buildables` constraint, got expected filtering. Reviewers: yelirekim, chad Reviewed By: chad Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T11473 Differential Revision: https://secure.phabricator.com/D16395
This commit is contained in:
parent
65e964fca1
commit
99889a6321
1 changed files with 4 additions and 0 deletions
|
@ -61,6 +61,10 @@ final class HarbormasterBuildSearchEngine
|
|||
$query->withBuildPlanPHIDs($map['plans']);
|
||||
}
|
||||
|
||||
if ($map['buildables']) {
|
||||
$query->withBuildablePHIDs($map['buildables']);
|
||||
}
|
||||
|
||||
if ($map['statuses']) {
|
||||
$query->withBuildStatuses($map['statuses']);
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue