diff --git a/src/applications/conduit/controller/api/PhabricatorConduitAPIController.php b/src/applications/conduit/controller/api/PhabricatorConduitAPIController.php index 5b00396236..2c9f81692a 100644 --- a/src/applications/conduit/controller/api/PhabricatorConduitAPIController.php +++ b/src/applications/conduit/controller/api/PhabricatorConduitAPIController.php @@ -81,7 +81,11 @@ class PhabricatorConduitAPIController $api_request = new ConduitAPIRequest($params); - if ($method_handler->shouldRequireAuthentication()) { + if ($request->getUser()->getPHID()) { + $auth_okay = true; + } else if (!$method_handler->shouldRequireAuthentication()) { + $auth_okay = true; + } else { $session_key = idx($metadata, 'sessionKey'); if (!$session_key) { $auth_okay = false; @@ -97,6 +101,7 @@ class PhabricatorConduitAPIController $session_key); if (!$session) { $auth_okay = false; + $result = null; $error_code = 'ERR-INVALID-SESSION'; $error_info = 'Session key is invalid.'; } else { @@ -105,8 +110,6 @@ class PhabricatorConduitAPIController } } // TODO: When we session, read connectionID from the session table. - } else { - $auth_okay = true; } if ($auth_okay) { diff --git a/src/applications/conduit/method/differential/find/ConduitAPI_differential_find_Method.php b/src/applications/conduit/method/differential/find/ConduitAPI_differential_find_Method.php index 4632f39808..fc4b986f1e 100644 --- a/src/applications/conduit/method/differential/find/ConduitAPI_differential_find_Method.php +++ b/src/applications/conduit/method/differential/find/ConduitAPI_differential_find_Method.php @@ -27,7 +27,7 @@ class ConduitAPI_differential_find_Method extends ConduitAPIMethod { DifferentialRevisionListData::QUERY_OPEN_OWNED, DifferentialRevisionListData::QUERY_COMMITTABLE, DifferentialRevisionListData::QUERY_REVISION_IDS, - DifferentialRevisionListData::QUERY_BY_PHID, + DifferentialRevisionListData::QUERY_PHIDS, ); $types = implode(', ', $types);