revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 03:50:54 +01:00
Code Issues Releases Wiki Activity

Use more explicit language for unassigning tasks

Browse source 
Summary:
Ref T10493.

  - Call this action "Unassigned" instead of "Up For Grabs", since the latter implies that it's OK for anyone to grab it, which is a social/context thing that we probably shouldn't assume.
  - Show who a task was previously assigned to in the transaction.

The text is a little clunky, yell if you've got a better wording? Or maybe I'll come up with something.

Test Plan: {F1166299}

Reviewers: chad

Reviewed By: chad

Subscribers: cburroughs

Maniphest Tasks: T10493

Differential Revision: https://secure.phabricator.com/D15454
This commit is contained in:
epriestley 2016-03-09 18:46:47 -08:00
parent ca4c0db2c1
commit 99bc1b05d7
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/maniphest/storage/ManiphestTransaction.php
View file

@ -301,7 +301,7 @@ final class ManiphestTransaction
if ($this->getAuthorPHID() == $new) { if ($this->getAuthorPHID() == $new) {
return pht('Claimed'); return pht('Claimed');
} else if (!$new) { } else if (!$new) {
return pht('Up For Grabs'); return pht('Unassigned');
} else if (!$old) { } else if (!$old) {
return pht('Assigned'); return pht('Assigned');
} else { } else {
@ -547,8 +547,9 @@ final class ManiphestTransaction
$this->renderHandleLink($author_phid)); $this->renderHandleLink($author_phid));
} else if (!$new) { } else if (!$new) {
return pht( return pht(
'%s placed this task up for grabs.', '%s removed %s as the assignee of this task.',
$this->renderHandleLink($author_phid)); $this->renderHandleLink($author_phid),
$this->renderHandleLink($old));
} else if (!$old) { } else if (!$old) {
return pht( return pht(
'%s assigned this task to %s.', '%s assigned this task to %s.',