revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 04:42:40 +01:00
Code Issues Releases Wiki Activity

Soften checks on a very old Maniphest transactionmigration

Browse source 
Summary:
Ref T9464. If an ancient transaction doesn't have array values for whatever reason, we fail here.

Instead, just recover as gracefully as we can. We may get the transaction "wrong" in some sense, but this only impacts what is rendered in the transaction log.

Test Plan: This is nearly a year old and there's no real way to test it.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9464

Differential Revision: https://secure.phabricator.com/D14149
This commit is contained in:
epriestley 2015-09-23 19:18:44 -07:00
parent 3379904237
commit 99e4472447
1 changed files with 32 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
resources/sql/autopatches/20141222.maniphestprojtxn.php
View file

@ -9,14 +9,18 @@ $metadata = array(
'edge:type' => PhabricatorProjectObjectHasProjectEdgeType::EDGECONST, 'edge:type' => PhabricatorProjectObjectHasProjectEdgeType::EDGECONST,
); );
foreach (new LiskMigrationIterator($table) as $txn) { foreach (new LiskMigrationIterator($table) as $txn) {
// ManiphestTransaction::TYPE_PROJECTS if ($txn->getTransactionType() != 'projects') {
if ($txn->getTransactionType() == 'projects') { continue;
}
$old_value = mig20141222_build_edge_data( $old_value = mig20141222_build_edge_data(
$txn->getOldValue(), $txn->getOldValue(),
$txn->getObjectPHID()); $txn->getObjectPHID());
$new_value = mig20141222_build_edge_data( $new_value = mig20141222_build_edge_data(
$txn->getNewvalue(), $txn->getNewValue(),
$txn->getObjectPHID()); $txn->getObjectPHID());
queryfx( queryfx(
$conn_w, $conn_w,
'UPDATE %T SET '. 'UPDATE %T SET '.
@ -29,21 +33,29 @@ foreach (new LiskMigrationIterator($table) as $txn) {
json_encode($metadata), json_encode($metadata),
$txn->getID()); $txn->getID());
} }
}
echo pht('Done.')."\n"; echo pht('Done.')."\n";
function mig20141222_build_edge_data(array $project_phids, $task_phid) { function mig20141222_build_edge_data($project_phids, $task_phid) {
$edge_data = array(); $edge_data = array();
// See T9464. If we didn't get a proper array value out of the transaction,
// just return an empty value so we can move forward.
if (!is_array($project_phids)) {
return $edge_data;
}
foreach ($project_phids as $project_phid) { foreach ($project_phids as $project_phid) {
if (!is_scalar($project_phid)) { if (!is_scalar($project_phid)) {
continue; continue;
} }
$edge_data[$project_phid] = array( $edge_data[$project_phid] = array(
'src' => $task_phid, 'src' => $task_phid,
'type' => PhabricatorProjectObjectHasProjectEdgeType::EDGECONST, 'type' => PhabricatorProjectObjectHasProjectEdgeType::EDGECONST,
'dst' => $project_phid, 'dst' => $project_phid,
); );
} }
return $edge_data; return $edge_data;
} }