revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
Code Issues Releases Wiki Activity

Don't show empty attributes.

Browse source 
Summary: Some places we pass in empty strings and get hanging middots. Would prefer not have the middot, and let the developer decide if they should set a 'nothing here' state.

Test Plan: Checked Repositories with no lint messages.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5920
This commit is contained in:
Chad Little 2013-05-13 16:04:06 -07:00
parent 63c27b322c
commit 99f648e4eb
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/view/layout/PhabricatorObjectItemView.php
View file

@ -122,7 +122,9 @@ final class PhabricatorObjectItemView extends AphrontTagView {
}
public function addAttribute($attribute) {
$this->attributes[] = $attribute;
if (!empty($attribute)) {
$this->attributes[] = $attribute;
}
return $this;
}