render_tag -> tag: pinboards

Summary: Fix pinboard callsites.

Test Plan: Looked at Pholio and Macro.

Reviewers: vrana

Reviewed By: vrana

CC: aran

Maniphest Tasks: T2432

Differential Revision: https://secure.phabricator.com/D4690

src/applications/macro/controller/PhabricatorMacroListController.php

@@ -125,7 +125,7 @@ final class PhabricatorMacroListController
         if ($file->getAuthorPHID()) {
           $author_handle = $this->getHandle($file->getAuthorPHID());
           $item->appendChild(
-            'Created by '.$author_handle->renderLink());
+            pht('Created by %s', $author_handle->renderLink()));
         }
         $datetime = phabricator_date($file->getDateCreated(), $viewer);
         $item->appendChild(

src/view/layout/PhabricatorPinboardItemView.php

@@ -33,13 +33,12 @@ final class PhabricatorPinboardItemView extends AphrontView {
   public function render() {
     $header = null;
     if ($this->header) {
-      $header = hsprintf('<a href="%s">%s</a>', $this->uri, $this->header);
       $header = phutil_tag(
         'div',
         array(
           'class' => 'phabricator-pinboard-item-header',
         ),
-        $header);
+        phutil_tag('a', array('href' => $this->uri), $this->header));
     }
 
     $image = phutil_tag(
@@ -56,9 +55,9 @@ final class PhabricatorPinboardItemView extends AphrontView {
           'height'  => $this->imageHeight,
         )));
 
-    $content = $this->renderChildren();
+    $content = $this->renderHTMLChildren();
     if ($content) {
-      $content = phutil_render_tag(
+      $content = phutil_tag(
         'div',
         array(
           'class' => 'phabricator-pinboard-item-content',
@@ -71,7 +70,12 @@ final class PhabricatorPinboardItemView extends AphrontView {
       array(
         'class' => 'phabricator-pinboard-item-view',
       ),
-      array($header, $image, $content));
+      $this->renderHTMLView(
+        array(
+          $header,
+          $image,
+          $content,
+        )));
   }
 
 }

src/view/layout/PhabricatorPinboardView.php

@@ -26,12 +26,12 @@ final class PhabricatorPinboardView extends AphrontView {
         ->render();
     }
 
-    return phutil_render_tag(
+    return phutil_tag(
       'div',
       array(
         'class' => 'phabricator-pinboard-view',
       ),
-      $this->renderSingleView($this->items));
+      $this->renderHTMLView($this->items));
   }
 
 }