revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 13:30:55 +01:00
Code Issues Releases Wiki Activity

Audit - fix a bug with unloaded repositories

Browse source 
Summary:
...because its always at least the string <ATTACHABLE>...  Not sure when we'd hit this / see the TODO about making it better, but its definitely a logic bug right now.

(an update to D12347 helped me notice that this conditional is always hit and may fatal later)

Test Plan: NA

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12348
This commit is contained in:
Bob Trahan 2015-04-11 21:50:30 -07:00
parent ff4d562d84
commit 9a49c81393
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/audit/editor/PhabricatorAuditEditor.php
View file

@ -961,8 +961,8 @@ final class PhabricatorAuditEditor
// not every code path loads the repository so tread carefully // not every code path loads the repository so tread carefully
// TODO: They should, and then we should simplify this. // TODO: They should, and then we should simplify this.
if ($object->getRepository($assert_attached = false)) { $repository = $object->getRepository($assert_attached = false);
$repository = $object->getRepository(); if ($repository != PhabricatorLiskDAO::ATTACHABLE) {
if (!$repository->shouldPublish()) { if (!$repository->shouldPublish()) {
return false; return false;
} }