revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page of a user

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15318

Test Plan:
Applied these five changes on top of D25147 and D25153, and both `/p/username/`
and `/people/manage/userid/` finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15318

Differential Revision: https://we.phorge.it/D25167
This commit is contained in:
Andre Klapper 2023-05-01 22:03:09 +02:00
parent 5a76e8d262
commit 9aa8d09d31
5 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/people/menuitem/PhabricatorPeopleBadgesProfileMenuItem.php
View file

@ -22,7 +22,7 @@ final class PhabricatorPeopleBadgesProfileMenuItem
PhabricatorProfileMenuItemConfiguration $config) {
$name = $config->getMenuItemProperty('name');
if (strlen($name)) {
if (phutil_nonempty_string($name)) {
return $name;
}

2
src/applications/people/menuitem/PhabricatorPeopleCommitsProfileMenuItem.php
View file

@ -22,7 +22,7 @@ final class PhabricatorPeopleCommitsProfileMenuItem
PhabricatorProfileMenuItemConfiguration $config) {
$name = $config->getMenuItemProperty('name');
if (strlen($name)) {
if (phutil_nonempty_string($name)) {
return $name;
}

2
src/applications/people/menuitem/PhabricatorPeopleManageProfileMenuItem.php
View file

@ -22,7 +22,7 @@ final class PhabricatorPeopleManageProfileMenuItem
PhabricatorProfileMenuItemConfiguration $config) {
$name = $config->getMenuItemProperty('name');
if (strlen($name)) {
if (phutil_nonempty_string($name)) {
return $name;
}

2
src/applications/people/menuitem/PhabricatorPeopleRevisionsProfileMenuItem.php
View file

@ -22,7 +22,7 @@ final class PhabricatorPeopleRevisionsProfileMenuItem
PhabricatorProfileMenuItemConfiguration $config) {
$name = $config->getMenuItemProperty('name');
if (strlen($name)) {
if (phutil_nonempty_string($name)) {
return $name;
}

2
src/applications/people/menuitem/PhabricatorPeopleTasksProfileMenuItem.php
View file

@ -22,7 +22,7 @@ final class PhabricatorPeopleTasksProfileMenuItem
PhabricatorProfileMenuItemConfiguration $config) {
$name = $config->getMenuItemProperty('name');
if (strlen($name)) {
if (phutil_nonempty_string($name)) {
return $name;
}