From 9ae48d4026fcf4c87c69fb77155d4938140043e0 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 18 Jan 2016 07:28:23 -0800 Subject: [PATCH] Fix smushing of multiple values in Projects "Additional Hashtags" field Summary: Ref T10168. When we render this control, we currently don't put commas into the value correctly if there are multiple alternative hashtags. Test Plan: Edited a project with multiple alternate hashtags. Before change: they all got smushed together. After change: properly comma-separated. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10168 Differential Revision: https://secure.phabricator.com/D15045 --- .../editfield/PhabricatorStringListEditField.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/applications/transactions/editfield/PhabricatorStringListEditField.php b/src/applications/transactions/editfield/PhabricatorStringListEditField.php index 64cb1fe08c..74046be7ac 100644 --- a/src/applications/transactions/editfield/PhabricatorStringListEditField.php +++ b/src/applications/transactions/editfield/PhabricatorStringListEditField.php @@ -7,6 +7,11 @@ final class PhabricatorStringListEditField return new AphrontFormTextControl(); } + protected function getValueForControl() { + $value = $this->getValue(); + return implode(', ', $value); + } + protected function newConduitParameterType() { return new ConduitStringListParameterType(); }