revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 21:40:55 +01:00
Code Issues Releases Wiki Activity

Use the same icon for "Resigned" in Differential and Diffusion

Browse source 
Summary:
See PHI2015. Currently, "resigned" reviewers/auditors get different icons in Differential and Diffusion.

The Diffusion icon is exceptionally poor and confusing: it does not communicate "resigned" and it is similar to other icons.

For clarity and consistency, use the Differential icon (a grey "X") in both applications.

Test Plan: {F8492303}

Differential Revision: https://secure.phabricator.com/D21593
This commit is contained in:
epriestley 2021-03-04 09:19:23 -08:00
parent f3caf7e9fc
commit 9b6a030292
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/audit/constants/PhabricatorAuditStatusConstants.php
View file

@ -54,10 +54,12 @@ final class PhabricatorAuditStatusConstants extends Phobject {
case self::AUDIT_NOT_REQUIRED: case self::AUDIT_NOT_REQUIRED:
$color = 'blue'; $color = 'blue';
break; break;
case self::RESIGNED:
case self::CLOSED: case self::CLOSED:
$color = 'dark'; $color = 'dark';
break; break;
case self::RESIGNED:
$color = 'grey';
break;
default: default:
$color = 'bluegrey'; $color = 'bluegrey';
break; break;
@ -68,7 +70,6 @@ final class PhabricatorAuditStatusConstants extends Phobject {
public static function getStatusIcon($code) { public static function getStatusIcon($code) {
switch ($code) { switch ($code) {
case self::AUDIT_NOT_REQUIRED: case self::AUDIT_NOT_REQUIRED:
case self::RESIGNED:
$icon = PHUIStatusItemView::ICON_OPEN; $icon = PHUIStatusItemView::ICON_OPEN;
break; break;
case self::AUDIT_REQUIRED: case self::AUDIT_REQUIRED:
@ -82,6 +83,9 @@ final class PhabricatorAuditStatusConstants extends Phobject {
case self::CLOSED: case self::CLOSED:
$icon = PHUIStatusItemView::ICON_ACCEPT; $icon = PHUIStatusItemView::ICON_ACCEPT;
break; break;
case self::RESIGNED:
$icon = 'fa-times';
break;
default: default:
$icon = PHUIStatusItemView::ICON_QUESTION; $icon = PHUIStatusItemView::ICON_QUESTION;
break; break;