mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-22 14:52:41 +01:00
Fix information page about Read-only status
Summary:
This change fixes the following page on your Phorge/Phabricator:
/readonly/config/
If you visit that page (with or without read-only mode), the
following crash will happen:
Call to undefined method PlatformSymbols::getPlatformServerSymbol()
Fixes T15185
Probably the regression was introduced in this point:
rP4d3f0dc7c727e6fdc0e8cba0e8e8f2b8ef1bd16c
This change also renamed "administrator" to "Administrator" in the messages
from that specific page, both because I have great respect for Administrators
and also because that is how this word is spelled in most other places in Phorge.
Test Plan:
- Visit the page /readonly/config/
- It does not crash anymore and you can see that beautiful message
that - it seems - no person in the world has ever seen since a
whole year. Take a good look at this page: it is a precious treasure.
Reviewers: O1 Blessed Committers, avivey
Reviewed By: O1 Blessed Committers, avivey
Subscribers: speck, tobiaswiese, Matthew, Cigaryno
Maniphest Tasks: T15185
Differential Revision: https://we.phorge.it/D25091
This commit is contained in:
Valerio Bozzolan
parent
c6f56b8221
commit
9bc3c16b6e
2 changed files with 44 additions and 44 deletions
|
|
@ -10,7 +10,7 @@ return array(
|
|||
'conpherence.pkg.css' => '0e3cf785',
|
||||
'conpherence.pkg.js' => '020aebcf',
|
||||
'core.pkg.css' => 'f538846d',
|
||||
'core.pkg.js' => '6a2c22c2',
|
||||
'core.pkg.js' => '66c49ca1',
|
||||
'dark-console.pkg.js' => '187792c2',
|
||||
'differential.pkg.css' => '609e63d4',
|
||||
'differential.pkg.js' => 'c60bec1b',
|
||||
|
|
@ -257,7 +257,7 @@ return array(
|
|||
'rsrc/externals/javelin/lib/URI.js' => '2e255291',
|
||||
'rsrc/externals/javelin/lib/Vector.js' => 'e9c80beb',
|
||||
'rsrc/externals/javelin/lib/WebSocket.js' => 'fdc13e4e',
|
||||
'rsrc/externals/javelin/lib/Workflow.js' => 'd7ba6915',
|
||||
'rsrc/externals/javelin/lib/Workflow.js' => 'cc1553f3',
|
||||
'rsrc/externals/javelin/lib/__tests__/Cookie.js' => 'ca686f71',
|
||||
'rsrc/externals/javelin/lib/__tests__/DOM.js' => '4566e249',
|
||||
'rsrc/externals/javelin/lib/__tests__/JSON.js' => '710377ae',
|
||||
|
|
@ -265,7 +265,7 @@ return array(
|
|||
'rsrc/externals/javelin/lib/__tests__/behavior.js' => '8426ebeb',
|
||||
'rsrc/externals/javelin/lib/behavior.js' => '1b6acc2a',
|
||||
'rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js' => '89a1ae3a',
|
||||
'rsrc/externals/javelin/lib/control/typeahead/Typeahead.js' => 'd96e47a4',
|
||||
'rsrc/externals/javelin/lib/control/typeahead/Typeahead.js' => '0507519c',
|
||||
'rsrc/externals/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js' => 'a241536a',
|
||||
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js' => '22ee68a5',
|
||||
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js' => '23387297',
|
||||
|
|
@ -423,7 +423,7 @@ return array(
|
|||
'rsrc/js/application/projects/WorkboardCard.js' => '0392a5d8',
|
||||
'rsrc/js/application/projects/WorkboardCardTemplate.js' => '84f82dad',
|
||||
'rsrc/js/application/projects/WorkboardColumn.js' => 'c3d24e63',
|
||||
'rsrc/js/application/projects/WorkboardController.js' => 'b9d0c2f3',
|
||||
'rsrc/js/application/projects/WorkboardController.js' => '7474d31f',
|
||||
'rsrc/js/application/projects/WorkboardDropEffect.js' => '8e0aa661',
|
||||
'rsrc/js/application/projects/WorkboardHeader.js' => '111bfd2d',
|
||||
'rsrc/js/application/projects/WorkboardHeaderTemplate.js' => 'ebe83a6b',
|
||||
|
|
@ -453,7 +453,7 @@ return array(
|
|||
'rsrc/js/core/DragAndDropFileUpload.js' => '4370900d',
|
||||
'rsrc/js/core/DraggableList.js' => '0169e425',
|
||||
'rsrc/js/core/Favicon.js' => '7930776a',
|
||||
'rsrc/js/core/FileUpload.js' => 'ab85e184',
|
||||
'rsrc/js/core/FileUpload.js' => '331676ea',
|
||||
'rsrc/js/core/Hovercard.js' => '6199f752',
|
||||
'rsrc/js/core/HovercardList.js' => 'de4b4919',
|
||||
'rsrc/js/core/KeyboardShortcut.js' => '1a844c06',
|
||||
|
|
@ -731,7 +731,7 @@ return array(
|
|||
'javelin-sound' => 'd4cc2d2a',
|
||||
'javelin-stratcom' => '0889b835',
|
||||
'javelin-tokenizer' => '89a1ae3a',
|
||||
'javelin-typeahead' => 'd96e47a4',
|
||||
'javelin-typeahead' => '0507519c',
|
||||
'javelin-typeahead-composite-source' => '22ee68a5',
|
||||
'javelin-typeahead-normalizer' => 'a241536a',
|
||||
'javelin-typeahead-ondemand-source' => '23387297',
|
||||
|
|
@ -751,12 +751,12 @@ return array(
|
|||
'javelin-workboard-card' => '0392a5d8',
|
||||
'javelin-workboard-card-template' => '84f82dad',
|
||||
'javelin-workboard-column' => 'c3d24e63',
|
||||
'javelin-workboard-controller' => 'b9d0c2f3',
|
||||
'javelin-workboard-controller' => '7474d31f',
|
||||
'javelin-workboard-drop-effect' => '8e0aa661',
|
||||
'javelin-workboard-header' => '111bfd2d',
|
||||
'javelin-workboard-header-template' => 'ebe83a6b',
|
||||
'javelin-workboard-order-template' => '03e8891f',
|
||||
'javelin-workflow' => 'd7ba6915',
|
||||
'javelin-workflow' => 'cc1553f3',
|
||||
'maniphest-report-css' => '3d53188b',
|
||||
'maniphest-task-edit-css' => '272daa84',
|
||||
'maniphest-task-summary-css' => '61d1667e',
|
||||
|
|
@ -787,7 +787,7 @@ return array(
|
|||
'phabricator-fatal-config-template-css' => 'e689dbbd',
|
||||
'phabricator-favicon' => '7930776a',
|
||||
'phabricator-feed-css' => 'd8b6e3f8',
|
||||
'phabricator-file-upload' => 'ab85e184',
|
||||
'phabricator-file-upload' => '331676ea',
|
||||
'phabricator-flag-css' => '2b77be8d',
|
||||
'phabricator-keyboard-shortcut' => '1a844c06',
|
||||
'phabricator-keyboard-shortcut-manager' => '81debc48',
|
||||
|
|
@ -965,6 +965,12 @@ return array(
|
|||
'javelin-dom',
|
||||
'javelin-workflow',
|
||||
),
|
||||
'0507519c' => array(
|
||||
'javelin-install',
|
||||
'javelin-dom',
|
||||
'javelin-vector',
|
||||
'javelin-util',
|
||||
),
|
||||
'05d290ef' => array(
|
||||
'javelin-install',
|
||||
'javelin-util',
|
||||
|
|
@ -1207,6 +1213,11 @@ return array(
|
|||
'javelin-stratcom',
|
||||
'javelin-dom',
|
||||
),
|
||||
'331676ea' => array(
|
||||
'javelin-install',
|
||||
'javelin-dom',
|
||||
'phabricator-notification',
|
||||
),
|
||||
34450586 => array(
|
||||
'javelin-color',
|
||||
'javelin-install',
|
||||
|
|
@ -1589,6 +1600,16 @@ return array(
|
|||
'javelin-behavior',
|
||||
'javelin-dom',
|
||||
),
|
||||
'7474d31f' => array(
|
||||
'javelin-install',
|
||||
'javelin-dom',
|
||||
'javelin-util',
|
||||
'javelin-vector',
|
||||
'javelin-stratcom',
|
||||
'javelin-workflow',
|
||||
'phabricator-drag-and-drop-file-upload',
|
||||
'javelin-workboard-board',
|
||||
),
|
||||
'78bc5d94' => array(
|
||||
'javelin-behavior',
|
||||
'javelin-uri',
|
||||
|
|
@ -1856,11 +1877,6 @@ return array(
|
|||
'javelin-json',
|
||||
'phuix-form-control-view',
|
||||
),
|
||||
'ab85e184' => array(
|
||||
'javelin-install',
|
||||
'javelin-dom',
|
||||
'phabricator-notification',
|
||||
),
|
||||
'ac10c917' => array(
|
||||
'javelin-behavior',
|
||||
'javelin-dom',
|
||||
|
|
@ -1983,16 +1999,6 @@ return array(
|
|||
'javelin-uri',
|
||||
'phabricator-notification',
|
||||
),
|
||||
'b9d0c2f3' => array(
|
||||
'javelin-install',
|
||||
'javelin-dom',
|
||||
'javelin-util',
|
||||
'javelin-vector',
|
||||
'javelin-stratcom',
|
||||
'javelin-workflow',
|
||||
'phabricator-drag-and-drop-file-upload',
|
||||
'javelin-workboard-board',
|
||||
),
|
||||
'bf159129' => array(
|
||||
'phui-inline-comment-view-css',
|
||||
),
|
||||
|
|
@ -2034,6 +2040,17 @@ return array(
|
|||
'javelin-workflow',
|
||||
'javelin-json',
|
||||
),
|
||||
'cc1553f3' => array(
|
||||
'javelin-stratcom',
|
||||
'javelin-request',
|
||||
'javelin-dom',
|
||||
'javelin-vector',
|
||||
'javelin-install',
|
||||
'javelin-util',
|
||||
'javelin-mask',
|
||||
'javelin-uri',
|
||||
'javelin-routable',
|
||||
),
|
||||
'cc2c5de5' => array(
|
||||
'javelin-install',
|
||||
'phuix-button-view',
|
||||
|
|
@ -2063,17 +2080,6 @@ return array(
|
|||
'd4cc2d2a' => array(
|
||||
'javelin-install',
|
||||
),
|
||||
'd7ba6915' => array(
|
||||
'javelin-stratcom',
|
||||
'javelin-request',
|
||||
'javelin-dom',
|
||||
'javelin-vector',
|
||||
'javelin-install',
|
||||
'javelin-util',
|
||||
'javelin-mask',
|
||||
'javelin-uri',
|
||||
'javelin-routable',
|
||||
),
|
||||
'd7d3ba75' => array(
|
||||
'javelin-dom',
|
||||
'javelin-util',
|
||||
|
|
@ -2094,12 +2100,6 @@ return array(
|
|||
'javelin-util',
|
||||
'phabricator-shaped-request',
|
||||
),
|
||||
'd96e47a4' => array(
|
||||
'javelin-install',
|
||||
'javelin-dom',
|
||||
'javelin-vector',
|
||||
'javelin-util',
|
||||
),
|
||||
'da15d3dc' => array(
|
||||
'phui-oi-list-view-css',
|
||||
),
|
||||
|
|
|
|||
|
|
@ -16,7 +16,7 @@ final class PhabricatorSystemReadOnlyController
|
|||
case PhabricatorEnv::READONLY_CONFIG:
|
||||
$title = pht('Administrative Read-Only Mode');
|
||||
$body[] = pht(
|
||||
'An administrator has placed this server into read-only mode.');
|
||||
'An Administrator has placed this server into read-only mode.');
|
||||
$body[] = pht(
|
||||
'This mode may be used to perform temporary maintenance, test '.
|
||||
'configuration, or archive an installation permanently.');
|
||||
|
|
@ -26,7 +26,7 @@ final class PhabricatorSystemReadOnlyController
|
|||
'has been turned on by rolling your chair away from your desk and '.
|
||||
'yelling "Hey! Why is %s in read-only mode??!" using '.
|
||||
'your very loudest outside voice.',
|
||||
PlatformSymbols::getPlatformServerSymbol());
|
||||
PlatformSymbols::getPlatformServerName());
|
||||
$body[] = pht(
|
||||
'This mode is active because it is enabled in the configuration '.
|
||||
'option "%s".',
|
||||
|
|
@ -110,7 +110,7 @@ final class PhabricatorSystemReadOnlyController
|
|||
|
||||
if ($viewer->getIsAdmin()) {
|
||||
$body[] = pht(
|
||||
'As an administrator, you can review status information from the '.
|
||||
'As an Administrator, you can review status information from the '.
|
||||
'%s control panel. This may provide more information about the '.
|
||||
'current state of affairs.',
|
||||
phutil_tag(
|
||||
|
|
|
|||
Loading…
Reference in a new issue