Remove "arcanist project" fields

Summary: Ref T7604. Remove these "arcanist project" fields from the `LiskDAO` classes, but leave the data intact (there are no more read/writes to this data).

Test Plan:
- Grepped for calls to these methods.
- Ran `./bin/storage adjust` to check for schema issues.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7604

Differential Revision: https://secure.phabricator.com/D13012

src/applications/differential/storage/DifferentialDiff.php

@@ -37,7 +37,6 @@ final class DifferentialDiff
 
   private $unsavedChangesets = array();
   private $changesets = self::ATTACHABLE;
-  private $arcanistProject = self::ATTACHABLE;
   private $revision = self::ATTACHABLE;
   private $properties = array();
 
@@ -108,25 +107,6 @@ final class DifferentialDiff
       $this->getID());
   }
 
-  public function attachArcanistProject(
-    PhabricatorRepositoryArcanistProject $project = null) {
-    $this->arcanistProject = $project;
-    return $this;
-  }
-
-  public function getArcanistProject() {
-    return $this->assertAttached($this->arcanistProject);
-  }
-
-  public function getArcanistProjectName() {
-    $name = '';
-    if ($this->arcanistProject) {
-      $project = $this->getArcanistProject();
-      $name = $project->getName();
-    }
-    return $name;
-  }
-
   public function save() {
     $this->openTransaction();
       $ret = parent::save();

src/applications/releeph/storage/ReleephProject.php

@@ -23,7 +23,6 @@ final class ReleephProject extends ReleephDAO
   protected $details = array();
 
   private $repository = self::ATTACHABLE;
-  private $arcanistProject = self::ATTACHABLE;
 
   protected function getConfiguration() {
     return array(
@@ -68,16 +67,6 @@ final class ReleephProject extends ReleephDAO
     return $this;
   }
 
-  public function getArcanistProject() {
-    return $this->assertAttached($this->arcanistProject);
-  }
-
-  public function attachArcanistProject(
-    PhabricatorRepositoryArcanistProject $arcanist_project = null) {
-    $this->arcanistProject = $arcanist_project;
-    return $this;
-  }
-
   public function getPushers() {
     return $this->getDetail('pushers', array());
   }