revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-04-04 16:38:24 +02:00
Code Issues Releases Wiki Activity

Remove "Editable By" description fields in Passphrase, Phame, and Spaces

Browse source 
Summary:
Ref T13411. These three applications render an "Editable By: <policy>" field in their descriptions.

The pages that these appear on all have "Edit <thing>" actions which either tell you the policy or allow you to discover the policy, and this field is unusual (the vast majority of objects don't have it). I think it largely got copy/pasted or used as space-filler and doesn't offer much of value.

Remove it to simplify/standardize these pages and make changes to how this field works simpler to implement.

Test Plan: Viewed a Credential, Blog, and Space; no longer saw the "Editable By" field.

Maniphest Tasks: T13411

Differential Revision: https://secure.phabricator.com/D20802
This commit is contained in:
epriestley 2019-09-11 21:51:27 -07:00
parent a35d7c3c21
commit 9c6969e810
3 changed files with 0 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/passphrase/controller/PassphraseCredentialViewController.php
View file

@ -190,14 +190,6 @@ final class PassphraseCredentialViewController extends PassphraseController {
pht('Credential Type'), pht('Credential Type'),
$type->getCredentialTypeName()); $type->getCredentialTypeName());
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
$viewer,
$credential);
$properties->addProperty(
pht('Editable By'),
$descriptions[PhabricatorPolicyCapability::CAN_EDIT]);
if ($type->shouldRequireUsername()) { if ($type->shouldRequireUsername()) {
$properties->addProperty( $properties->addProperty(
pht('Username'), pht('Username'),

8
src/applications/phame/controller/blog/PhameBlogManageController.php
View file

@ -143,14 +143,6 @@ final class PhameBlogManageController extends PhameBlogController {
), ),
$feed_uri)); $feed_uri));
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
$viewer,
$blog);
$properties->addProperty(
pht('Editable By'),
$descriptions[PhabricatorPolicyCapability::CAN_EDIT]);
$engine = id(new PhabricatorMarkupEngine()) $engine = id(new PhabricatorMarkupEngine())
->setViewer($viewer) ->setViewer($viewer)
->addObject($blog, PhameBlog::MARKUP_FIELD_DESCRIPTION) ->addObject($blog, PhameBlog::MARKUP_FIELD_DESCRIPTION)

8
src/applications/spaces/controller/PhabricatorSpacesViewController.php
View file

@ -80,14 +80,6 @@ final class PhabricatorSpacesViewController
? pht('Yes') ? pht('Yes')
: pht('No')); : pht('No'));
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
$viewer,
$space);
$list->addProperty(
pht('Editable By'),
$descriptions[PhabricatorPolicyCapability::CAN_EDIT]);
$description = $space->getDescription(); $description = $space->getDescription();
if (strlen($description)) { if (strlen($description)) {
$description = new PHUIRemarkupView($viewer, $description); $description = new PHUIRemarkupView($viewer, $description);