revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 11:30:55 +01:00
Code Issues Releases Wiki Activity

Fix "unmarked 0 inline comments as not undone" transactions

Browse source 
Summary:
Fixes T8483. I did this incorrectly in D13159, by doing it correctly first and then editing it carelessly. For most transaction types, it didn't matter, but did for inline state.

Also, clean up any bad inline state transactions.

Test Plan:
  - Ran migration, bad transactions vanished.
  - Marked some inline comments as done.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8483

Differential Revision: https://secure.phabricator.com/D13226
This commit is contained in:
epriestley 2015-06-09 13:30:45 -07:00
parent b8b4279a8a
commit 9c82881cac
2 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
resources/sql/autopatches/20150609.inline.sql Normal file
View file

@ -0,0 +1,4 @@
/* This cleans up some errant transactions, see T8483. */
DELETE FROM {$NAMESPACE}_differential.differential_transaction
WHERE transactionType = 'core:inlinestate' AND newValue = 'null';

1
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
View file

@ -356,6 +356,7 @@ abstract class PhabricatorApplicationTransactionEditor
case PhabricatorTransactions::TYPE_BUILDABLE:
case PhabricatorTransactions::TYPE_TOKEN:
case PhabricatorTransactions::TYPE_INLINESTATE:
return $xaction->getNewValue();
case PhabricatorTransactions::TYPE_SPACE:
$space_phid = $xaction->getNewValue();
if (!strlen($space_phid)) {