1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00

Restore psyduck to his proper place

Summary: Fixes T4665. The "attachable" logic was a little off after a recent change.

Test Plan: With and without a profile image, viewed a page.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T4665

Differential Revision: https://secure.phabricator.com/D8594
This commit is contained in:
epriestley 2014-03-22 12:15:13 -07:00
parent b849f8920d
commit 9c872749a0

View file

@ -652,7 +652,7 @@ EOBODY;
} }
public function loadProfileImageURI() { public function loadProfileImageURI() {
if ($this->profileImage && $this->profileImage !== self::ATTACHABLE) { if ($this->profileImage && ($this->profileImage !== self::ATTACHABLE)) {
return $this->profileImage; return $this->profileImage;
} }
@ -664,13 +664,11 @@ EOBODY;
$file = id(new PhabricatorFile())->loadOneWhere('phid = %s', $src_phid); $file = id(new PhabricatorFile())->loadOneWhere('phid = %s', $src_phid);
if ($file) { if ($file) {
$this->profileImage = $file->getBestURI(); $this->profileImage = $file->getBestURI();
return $this->profileImage;
} }
} }
if (!$this->profileImage) {
$this->profileImage = self::getDefaultProfileImageURI(); $this->profileImage = self::getDefaultProfileImageURI();
}
return $this->profileImage; return $this->profileImage;
} }