From 9c87ba8b09a79db6655b99fd58258fe682ae2064 Mon Sep 17 00:00:00 2001
From: Gareth Evans <garoevans@gmail.com>
Date: Mon, 13 May 2013 08:09:08 -0700
Subject: [PATCH] parse with %s as `number_format()` returns stirng

Summary:
`number_format()` returns a string, so if passed a number greater than 999 by default it will add commas, which parsed by %d will only return the 1000's delimter.

```echo sprintf("%d", number_format(1000)); // Outputs 1
echo sprintf("%s", number_format(1000)); // Outputs 1,000

Test Plan: Looked at repos with over 999 commits.

Reviewers: epriestley, chad

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5913
---
 .../diffusion/controller/DiffusionHomeController.php          | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/applications/diffusion/controller/DiffusionHomeController.php b/src/applications/diffusion/controller/DiffusionHomeController.php
index 237305145c..ba9caf98c9 100644
--- a/src/applications/diffusion/controller/DiffusionHomeController.php
+++ b/src/applications/diffusion/controller/DiffusionHomeController.php
@@ -94,7 +94,7 @@ final class DiffusionHomeController extends DiffusionController {
             'callsign' => $repository->getCallsign(),
             'action' => 'history',
           )),
-          pht('%d Commits', number_format($size)));
+          pht('%s Commits', new PhutilNumber($size)));
       }
 
       $lint_count = '';
@@ -110,7 +110,7 @@ final class DiffusionHomeController extends DiffusionController {
               'action' => 'lint',
             )),
           ),
-          pht('%d Lint Messages', number_format($lint_branches[$branch])));
+          pht('%s Lint Messages', new PhutilNumber($lint_branches[$branch])));
       }
 
       $datetime = '';