revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 19:40:55 +01:00
Code Issues Releases Wiki Activity

Add a Read More link to PHUIDocumentSummaryView

Browse source 
Summary: Currently it's difficult to notice posts may be much longer than the summary (in most cases, actually), Adds a consistent "Read More" link to the full post. Also made sure "violet" was more consistantly used.

Test Plan:
Review summaries in Phame

{F1031799}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14827
This commit is contained in:
Chad Little 2015-12-19 12:28:18 -08:00
parent 4daf2eb5de
commit 9d1ba9c038
4 changed files with 35 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
resources/celerity/map.php
View file

@ -82,7 +82,7 @@ return array(
'rsrc/css/application/owners/owners-path-editor.css' => '2f00933b', 'rsrc/css/application/owners/owners-path-editor.css' => '2f00933b',
'rsrc/css/application/paste/paste.css' => 'a5157c48', 'rsrc/css/application/paste/paste.css' => 'a5157c48',
'rsrc/css/application/people/people-profile.css' => '25970776', 'rsrc/css/application/people/people-profile.css' => '25970776',
'rsrc/css/application/phame/phame.css' => '164515da', 'rsrc/css/application/phame/phame.css' => '09a39e8d',
'rsrc/css/application/pholio/pholio-edit.css' => '3ad9d1ee', 'rsrc/css/application/pholio/pholio-edit.css' => '3ad9d1ee',
'rsrc/css/application/pholio/pholio-inline-comments.css' => '8e545e49', 'rsrc/css/application/pholio/pholio-inline-comments.css' => '8e545e49',
'rsrc/css/application/pholio/pholio.css' => '95174bdd', 'rsrc/css/application/pholio/pholio.css' => '95174bdd',
@ -127,7 +127,7 @@ return array(
'rsrc/css/phui/phui-button.css' => '16020a60', 'rsrc/css/phui/phui-button.css' => '16020a60',
'rsrc/css/phui/phui-crumbs-view.css' => '414406b5', 'rsrc/css/phui/phui-crumbs-view.css' => '414406b5',
'rsrc/css/phui/phui-document-pro.css' => 'e0fad431', 'rsrc/css/phui/phui-document-pro.css' => 'e0fad431',
'rsrc/css/phui/phui-document-summary.css' => '8c1e0aca', 'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
'rsrc/css/phui/phui-document.css' => 'a4a1c3b9', 'rsrc/css/phui/phui-document.css' => 'a4a1c3b9',
'rsrc/css/phui/phui-feed-story.css' => 'b7b26d23', 'rsrc/css/phui/phui-feed-story.css' => 'b7b26d23',
'rsrc/css/phui/phui-fontkit.css' => '9cda225e', 'rsrc/css/phui/phui-fontkit.css' => '9cda225e',
@ -780,7 +780,7 @@ return array(
'phabricator-uiexample-reactor-sendclass' => '1def2711', 'phabricator-uiexample-reactor-sendclass' => '1def2711',
'phabricator-uiexample-reactor-sendproperties' => 'b1f0ccee', 'phabricator-uiexample-reactor-sendproperties' => 'b1f0ccee',
'phabricator-zindex-css' => '57ddcaa2', 'phabricator-zindex-css' => '57ddcaa2',
'phame-css' => '164515da', 'phame-css' => '09a39e8d',
'pholio-css' => '95174bdd', 'pholio-css' => '95174bdd',
'pholio-edit-css' => '3ad9d1ee', 'pholio-edit-css' => '3ad9d1ee',
'pholio-inline-comments-css' => '8e545e49', 'pholio-inline-comments-css' => '8e545e49',
@ -798,7 +798,7 @@ return array(
'phui-calendar-list-css' => 'c1c7f338', 'phui-calendar-list-css' => 'c1c7f338',
'phui-calendar-month-css' => '476be7e0', 'phui-calendar-month-css' => '476be7e0',
'phui-crumbs-view-css' => '414406b5', 'phui-crumbs-view-css' => '414406b5',
'phui-document-summary-view-css' => '8c1e0aca', 'phui-document-summary-view-css' => '9ca48bdf',
'phui-document-view-css' => 'a4a1c3b9', 'phui-document-view-css' => 'a4a1c3b9',
'phui-document-view-pro-css' => 'e0fad431', 'phui-document-view-pro-css' => 'e0fad431',
'phui-feed-story-css' => 'b7b26d23', 'phui-feed-story-css' => 'b7b26d23',

10
src/view/phui/PHUIDocumentSummaryView.php
View file

@ -90,7 +90,15 @@ final class PHUIDocumentSummaryView extends AphrontTagView {
), ),
$this->summary); $this->summary);
return array($header, $subtitle, $body); $read_more = phutil_tag(
'a',
array(
'class' => 'phui-document-read-more',
'href' => $this->href,
),
pht('Read more...'));
return array($header, $subtitle, $body, $read_more);
} }
} }

6
webroot/rsrc/css/application/phame/phame.css
View file

@ -85,7 +85,7 @@
} }
.phame-blog-list-title:hover { .phame-blog-list-title:hover {
color: {$indigo}; color: {$violet};
text-decoration: none; text-decoration: none;
} }
@ -120,12 +120,12 @@
} }
.phame-blog-list-new-post:hover { .phame-blog-list-new-post:hover {
color: {$indigo}; color: {$violet};
text-decoration: none; text-decoration: none;
} }
.phame-blog-list-new-post:hover .phame-blog-list-icon { .phame-blog-list-new-post:hover .phame-blog-list-icon {
color: {$indigo}; color: {$violet};
} }
.phame-blog-list-icon { .phame-blog-list-icon {

19
webroot/rsrc/css/phui/phui-document-summary.css
View file

@ -25,6 +25,21 @@ body .phui-document-view .phui-document-summary-view h2.remarkup-header {
text-decoration: none; text-decoration: none;
} }
.phui-document-view .phui-document-summary-body div.phabricator-remarkup {
padding-bottom: 4px;
}
a.phui-document-read-more {
color: {$lightgreytext};
font-size: {$smallerfontsize};
display: block;
padding-bottom: 12px;
}
a.phui-document-read-more:hover {
color: {$violet};
}
.phui-document-summary-subtitle { .phui-document-summary-subtitle {
color: {$lightgreytext}; color: {$lightgreytext};
font-size: {$normalfontsize}; font-size: {$normalfontsize};
@ -33,3 +48,7 @@ body .phui-document-view .phui-document-summary-view h2.remarkup-header {
.phui-document-summary-subtitle a { .phui-document-summary-subtitle a {
color: {$darkbluetext}; color: {$darkbluetext};
} }
.phui-document-summary-subtitle a:hover {
color: {$violet};
}