revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 23:02:42 +01:00
Code Issues Releases Wiki Activity

More resilient timeline icon layout

Browse source 
Summary: center aligns the icons in the fill area, removes some of the positioning jank. Also set new icons for maniphest custom.

Test Plan: test desktop and mobile layouts, tested thin pins for proper centering.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T4866

Differential Revision: https://secure.phabricator.com/D8839
This commit is contained in:
Chad Little 2014-04-22 14:24:36 -07:00
parent 11fd6afeb1
commit 9d3f8117e7
5 changed files with 14 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
resources/celerity/map.php
View file

@ -144,7 +144,7 @@ return array(
'rsrc/css/phui/phui-status.css' => '2f562399',
'rsrc/css/phui/phui-tag-view.css' => '295d81c4',
'rsrc/css/phui/phui-text.css' => '23e9b4b7',
'rsrc/css/phui/phui-timeline-view.css' => '66803fc3',
'rsrc/css/phui/phui-timeline-view.css' => '7a502670',
'rsrc/css/phui/phui-workboard-view.css' => '84f2c272',
'rsrc/css/phui/phui-workpanel-view.css' => '97b69459',
'rsrc/css/sprite-actions.css' => '969ad0e5',
@ -764,7 +764,7 @@ return array(
'phui-status-list-view-css' => '2f562399',
'phui-tag-view-css' => '295d81c4',
'phui-text-css' => '23e9b4b7',
'phui-timeline-view-css' => '66803fc3',
'phui-timeline-view-css' => '7a502670',
'phui-workboard-view-css' => '84f2c272',
'phui-workpanel-view-css' => '97b69459',
'policy-css' => '957ea14c',

6
src/applications/differential/storage/DifferentialTransaction.php
View file

@ -351,11 +351,11 @@ final class DifferentialTransaction extends PhabricatorApplicationTransaction {
case self::TYPE_ACTION:
switch ($this->getNewValue()) {
case DifferentialAction::ACTION_CLOSE:
return 'fa-check-square-o';
case DifferentialAction::ACTION_ACCEPT:
return 'fa-check';
case DifferentialAction::ACTION_ACCEPT:
return 'fa-check-circle';
case DifferentialAction::ACTION_REJECT:
return 'fa-times';
return 'fa-times-circle';
case DifferentialAction::ACTION_ABANDON:
return 'fa-plane';
case DifferentialAction::ACTION_RETHINK:

6
src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php
View file

@ -102,7 +102,7 @@ final class PhabricatorManiphestConfigOptions
'duplicate' => array(
'name' => pht('Duplicate'),
'name.full' => pht('Closed, Duplicate'),
'transaction.icon' => 'delete',
'transaction.icon' => 'fa-times',
'special' => ManiphestTaskStatus::SPECIAL_DUPLICATE,
'closed' => true,
),
@ -110,7 +110,7 @@ final class PhabricatorManiphestConfigOptions
'name' => pht('Spite'),
'name.full' => pht('Closed, Spite'),
'name.action' => pht('Spited'),
'transaction.icon' => 'dislike',
'transaction.icon' => 'fa-thumbs-o-down',
'silly' => true,
'closed' => true,
'prefixes' => array(
@ -157,7 +157,7 @@ The keys you can provide in a specification are:
and it must be a closed status.
- `transaction.icon` //Optional string.// Allows you to choose a different
icon to use for this status when showing status changes in the transaction
log.
log. Please see UIExamples, Icons and Images for a list.
- `transaction.color` //Optional string.// Allows you to choose a different
color to use for this status when showing status changes in the transaction
log.

3
src/applications/maniphest/storage/ManiphestTransaction.php
View file

@ -263,7 +263,7 @@ final class ManiphestTransaction
}
if (ManiphestTaskStatus::isClosedStatus($new)) {
return 'fa-check-square-o';
return 'fa-check';
} else {
return 'fa-pencil';
}
@ -280,7 +280,6 @@ final class ManiphestTransaction
case self::TYPE_PRIORITY:
if ($old == ManiphestTaskPriority::getDefaultPriority()) {
return 'fa-arrow-right';
return pht('Triaged');
} else if ($old > $new) {
return 'fa-arrow-down';
} else {

14
webroot/rsrc/css/phui/phui-timeline-view.css
View file

@ -190,12 +190,13 @@
background-color: {$lightblueborder};
top: 0;
left: 0;
text-align: center;
}
.phui-timeline-icon {
position: absolute;
left: 9px;
top: -5px;
.phui-icon-view.phui-timeline-icon:before {
position: relative;
top: 4px;
margin: 0;
}
.phui-timeline-minor-event .phui-timeline-icon-fill {
@ -204,11 +205,6 @@
border-radius: 3px;
}
.phui-timeline-minor-event .phui-timeline-icon {
top: -5px;
left: 7px;
}
.phui-timeline-extra,
.phui-timeline-extra .phabricator-content-source-view {
font-size: 11px;