From 9d64beeaa345cddc4972015d2719d9aa33ecc01f Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 21 Jul 2014 06:44:35 -0700 Subject: [PATCH] Namespace `dateCreated` in Maniphest query construction Summary: Fixes T5661. We may now pick up a conflicting `dateCreated` field from an edge table join. Test Plan: Ran a project + dateCreated filtering query, no longer got an exception. Reviewers: btrahan, joshuaspence Reviewed By: joshuaspence Subscribers: epriestley Maniphest Tasks: T5661 Differential Revision: https://secure.phabricator.com/D9997 --- src/applications/maniphest/query/ManiphestTaskQuery.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/applications/maniphest/query/ManiphestTaskQuery.php b/src/applications/maniphest/query/ManiphestTaskQuery.php index 5c1d17bc8f..90eb3a8a14 100644 --- a/src/applications/maniphest/query/ManiphestTaskQuery.php +++ b/src/applications/maniphest/query/ManiphestTaskQuery.php @@ -206,28 +206,28 @@ final class ManiphestTaskQuery extends PhabricatorCursorPagedPolicyAwareQuery { if ($this->dateCreatedAfter) { $where[] = qsprintf( $conn, - 'dateCreated >= %d', + 'task.dateCreated >= %d', $this->dateCreatedAfter); } if ($this->dateCreatedBefore) { $where[] = qsprintf( $conn, - 'dateCreated <= %d', + 'task.dateCreated <= %d', $this->dateCreatedBefore); } if ($this->dateModifiedAfter) { $where[] = qsprintf( $conn, - 'dateModified >= %d', + 'task.dateModified >= %d', $this->dateModifiedAfter); } if ($this->dateModifiedBefore) { $where[] = qsprintf( $conn, - 'dateModified <= %d', + 'task.dateModified <= %d', $this->dateModifiedBefore); }