Add setup checks for unused homepage options

Summary: Ref T11533, Fixes T5315. Remove and add extra setup checks for removed homepage options.

Test Plan: Review text.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T5315, T11533

Differential Revision: https://secure.phabricator.com/D16453

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

@@ -143,6 +143,9 @@ final class PhabricatorExtraConfigSetupCheck extends PhabricatorSetupCheck {
       'phabricator.auth-permanent',
       'phabricator.application-id',
       'phabricator.application-secret',
+      'maniphest.priorities.unbreak-now',
+      'maniphest.priorities.needs-triage',
+      'welcome.html',
     );
 
     $ancient_config = array_fill_keys($auth_config, $reason_auth);
@@ -332,6 +335,19 @@ final class PhabricatorExtraConfigSetupCheck extends PhabricatorSetupCheck {
       'ui.custom-header' => pht(
         'This option has been replaced with `ui.logo`, which provides more '.
         'flexible configuration options.'),
+
+      'welcome.html' => pht(
+        'This option has been removed, you can use Dashboards to provide '.
+        'homepage customization. See T11533 for more details.'),
+
+      'maniphest.priorities.unbreak-now' => pht(
+        'This option has been removed, you can use Dashboards to provide '.
+        'homepage customization. See T11533 for more details.'),
+
+      'maniphest.priorities.needs-triage' => pht(
+        'This option has been removed, you can use Dashboards to provide '.
+        'homepage customization. See T11533 for more details.'),
+
     );
 
     return $ancient_config;

src/applications/config/option/PhabricatorCoreConfigOptions.php

@@ -213,10 +213,6 @@ final class PhabricatorCoreConfigOptions
         ->setLocked(true)
         ->setDescription(
           pht('Customized settings for Phabricator applications.')),
-      $this->newOption('welcome.html', 'string', null)
-        ->setLocked(true)
-        ->setDescription(
-          pht('Custom HTML to show on the main Phabricator dashboard.')),
       $this->newOption('phabricator.cache-namespace', 'string', 'phabricator')
         ->setLocked(true)
         ->setDescription(pht('Cache namespace.')),

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

@@ -356,28 +356,6 @@ EOTEXT
         'string',
         '[Maniphest]')
         ->setDescription(pht('Subject prefix for Maniphest mail.')),
-      $this->newOption(
-        'maniphest.priorities.unbreak-now',
-        'int',
-        100)
-        ->setSummary(pht('Priority used to populate "Unbreak Now" on home.'))
-        ->setDescription(
-          pht(
-            'Temporary setting. If set, this priority is used to populate the '.
-            '"Unbreak Now" panel on the home page. You should adjust this if '.
-            'you adjust priorities using `%s`.',
-            'maniphest.priorities')),
-      $this->newOption(
-        'maniphest.priorities.needs-triage',
-        'int',
-        90)
-        ->setSummary(pht('Priority used to populate "Needs Triage" on home.'))
-        ->setDescription(
-          pht(
-            'Temporary setting. If set, this priority is used to populate the '.
-            '"Needs Triage" panel on the home page. You should adjust this if '.
-            'you adjust priorities using `%s`.',
-            'maniphest.priorities')),
       $this->newOption('maniphest.points', $points_type, array())
         ->setSummary(pht('Configure point values for tasks.'))
         ->setDescription($points_description)