From 9e1a1577c3a2f66631d7babbe1e67c72a80f51bd Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 26 Jul 2018 09:42:36 -0700
Subject: [PATCH] Make the meme cache case-sensitive

Summary:
Fixes T13172. At one point we always capitalized all the text, and the cache uses capitalized text.

However, we stopped capitalizing the text at some point. Modern memes are more more subtle than old memes, and when we eventualy add support for things like "explodey brain" we'll certainly want to support mixed case.

Practically, this stops you from changing the capitalization of a cached meme. Get rid of the cache transform.

Test Plan:
none lul

(I don't have `gd` installed locally and buiding it requires building libjpeg and libpng or giving up and using `brew`. I'l vet this in production.)

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13172

Differential Revision: https://secure.phabricator.com/D19537
---
 src/applications/macro/engine/PhabricatorMemeEngine.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/applications/macro/engine/PhabricatorMemeEngine.php b/src/applications/macro/engine/PhabricatorMemeEngine.php
index 175aa2fb46..3e87a304c9 100644
--- a/src/applications/macro/engine/PhabricatorMemeEngine.php
+++ b/src/applications/macro/engine/PhabricatorMemeEngine.php
@@ -104,8 +104,8 @@ final class PhabricatorMemeEngine extends Phobject {
   private function newTransformHash() {
     $properties = array(
       'kind' => 'meme',
-      'above' => phutil_utf8_strtoupper($this->getAboveText()),
-      'below' => phutil_utf8_strtoupper($this->getBelowText()),
+      'above' => $this->getAboveText(),
+      'below' => $this->getBelowText(),
     );
 
     $properties = phutil_json_encode($properties);