From 9e54e6e886614ca076045e4854887b7ed60b60b8 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Mon, 8 Dec 2014 04:11:08 -0800 Subject: [PATCH] Fix an undefined variable Summary: The `$timeline` variable is undefined. I was seeing the following error in the logs: ``` EXCEPTION: (RuntimeException) Undefined variable: timeline at [/src/error/PhutilErrorHandler.php:210] #0 PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [/src/applications/harbormaster/controller/HarbormasterStepEditController.php:205] #1 HarbormasterStepEditController::processRequest() called at [/src/aphront/AphrontController.php:33] #2 AphrontController::handleRequest(AphrontRequest) called at [/webroot/index.php:103] ``` Test Plan: Created a build step without a fatal error. Reviewers: btrahan, hach-que, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D10941 --- .../harbormaster/controller/HarbormasterStepEditController.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/harbormaster/controller/HarbormasterStepEditController.php b/src/applications/harbormaster/controller/HarbormasterStepEditController.php index 403dfa8cce..a7c4624dc9 100644 --- a/src/applications/harbormaster/controller/HarbormasterStepEditController.php +++ b/src/applications/harbormaster/controller/HarbormasterStepEditController.php @@ -190,6 +190,7 @@ final class HarbormasterStepEditController extends HarbormasterController { if ($is_new) { $xaction_view = null; + $timeline = null; } else { $timeline = $this->buildTransactionTimeline( $step,