revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 07:12:41 +01:00
Code Issues Releases Wiki Activity

Fix Diviner issue when publishing new atoms

Browse source 
Summary: We need to make sure the symbol is always saved before the atom. I mucked this up recently and didn't catch it locally since I'd already generated the atoms.

Test Plan: Ran `bin/diviner generate` after truncating all diviner tables.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D6146
This commit is contained in:
epriestley 2013-06-06 09:09:08 -07:00
parent 1433a035c6
commit 9e591f488b
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/applications/diviner/publisher/DivinerLivePublisher.php
View file

@ -113,11 +113,6 @@ final class DivinerLivePublisher extends DivinerPublisher {
->setGroupName($ref->getGroup()); ->setGroupName($ref->getGroup());
if ($is_documentable) { if ($is_documentable) {
$storage = $this->loadAtomStorageForSymbol($symbol)
->setAtomData($atom->toDictionary())
->setContent(null)
->save();
$renderer = $this->getRenderer(); $renderer = $this->getRenderer();
$summary = $renderer->renderAtomSummary($atom); $summary = $renderer->renderAtomSummary($atom);
$summary = (string)phutil_safe_html($summary); $summary = (string)phutil_safe_html($summary);
@ -125,6 +120,13 @@ final class DivinerLivePublisher extends DivinerPublisher {
} }
$symbol->save(); $symbol->save();
if ($is_documentable) {
$storage = $this->loadAtomStorageForSymbol($symbol)
->setAtomData($atom->toDictionary())
->setContent(null)
->save();
}
} }
} }