revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-04-03 16:08:19 +02:00
Code Issues Releases Wiki Activity

Pull some constants out of the Asana bridge

Browse source 
Summary: Ref T2852. Reduce the number of magical strings in use, and prepare the Asana bridge for eventual workspace/project support (a little bit).

Test Plan: Verified enriched links still work properly.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2852

Differential Revision: https://secure.phabricator.com/D6301
This commit is contained in:
epriestley 2013-06-25 16:32:45 -07:00
parent d4ca508d2b
commit 9e82c01a8a
2 changed files with 23 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php
View file

@ -2,10 +2,24 @@
final class DoorkeeperBridgeAsana extends DoorkeeperBridge { final class DoorkeeperBridgeAsana extends DoorkeeperBridge {
const APPTYPE_ASANA = 'asana';
const APPDOMAIN_ASANA = 'asana.com';
const OBJTYPE_TASK = 'asana:task';
public function canPullRef(DoorkeeperObjectRef $ref) { public function canPullRef(DoorkeeperObjectRef $ref) {
return ($ref->getApplicationType() == 'asana') && if ($ref->getApplicationType() != self::APPTYPE_ASANA) {
($ref->getApplicationDomain() == 'asana.com') && return false;
($ref->getObjectType() == 'asana:task'); }
if ($ref->getApplicationDomain() != self::APPDOMAIN_ASANA) {
return false;
}
$types = array(
self::OBJTYPE_TASK => true,
);
return isset($types[$ref->getObjectType()]);
} }
public function pullRefs(array $refs) { public function pullRefs(array $refs) {

7
src/applications/doorkeeper/remarkup/DoorkeeperRemarkupRuleAsana.php
View file

@ -23,7 +23,12 @@ final class DoorkeeperRemarkupRuleAsana
'token' => $token, 'token' => $token,
'href' => $matches[0], 'href' => $matches[0],
'tag' => array( 'tag' => array(
'ref' => array('asana', 'asana.com', 'asana:task', $matches[2]), 'ref' => array(
DoorkeeperBridgeAsana::APPTYPE_ASANA,
DoorkeeperBridgeAsana::APPDOMAIN_ASANA,
DoorkeeperBridgeAsana::OBJTYPE_TASK,
$matches[2],
),
'extra' => array( 'extra' => array(
'asana.context' => $matches[1], 'asana.context' => $matches[1],
), ),