revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-01 03:02:43 +01:00
Code Issues Releases Wiki Activity

(stable) Fix a possible fatal on the first push to a cluster repository

Browse source 
Summary:
Fixes T11020. I think this resolves things -- `$new_version` (set above) should be used, not `$new_log` directly.

Specifically, we would get into trouble if the initial push failed for some reason (working copy not initialized yet, commit hook rejected, etc).

Test Plan: Made a bad push to a new repository. Saw it freeze before the patch and succeed afterwards.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11020

Differential Revision: https://secure.phabricator.com/D15969
This commit is contained in:
epriestley 2016-05-23 17:13:12 -07:00
parent 70b194398e
commit 9f399247b1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php
View file

@ -391,7 +391,7 @@ final class DiffusionRepositoryClusterEngine extends Phobject {
$repository_phid, $repository_phid,
$device_phid, $device_phid,
$this->clusterWriteVersion, $this->clusterWriteVersion,
$new_log->getID(), $new_version,
$this->clusterWriteOwner); $this->clusterWriteOwner);
$did_release = true; $did_release = true;
break; break;