Clean up feedback from D11340

Summary: Ref D11340, I missed the comments being to excited to land.

Test Plan: Shrink window to mobile view, click on action menu.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11347

resources/celerity/map.php

@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => '2b129813',
+    'core.pkg.css' => 'b99369cc',
     'core.pkg.js' => '61af8961',
     'darkconsole.pkg.js' => '8ab24e01',
     'differential.pkg.css' => '8af45893',
@@ -130,7 +130,7 @@ return array(
     'rsrc/css/phui/phui-fontkit.css' => '9c3d2dce',
     'rsrc/css/phui/phui-form-view.css' => 'aad06f2a',
     'rsrc/css/phui/phui-form.css' => '9aecbda1',
-    'rsrc/css/phui/phui-header-view.css' => '0873d56f',
+    'rsrc/css/phui/phui-header-view.css' => 'c936b5b9',
     'rsrc/css/phui/phui-icon.css' => 'a013a63d',
     'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8',
     'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
@@ -774,7 +774,7 @@ return array(
     'phui-fontkit-css' => '9c3d2dce',
     'phui-form-css' => '9aecbda1',
     'phui-form-view-css' => 'aad06f2a',
-    'phui-header-view-css' => '0873d56f',
+    'phui-header-view-css' => 'c936b5b9',
     'phui-icon-view-css' => 'a013a63d',
     'phui-image-mask-css' => '5a8b09c8',
     'phui-info-panel-css' => '27ea50a1',

src/view/phui/PHUIButtonView.php

@@ -22,9 +22,6 @@ final class PHUIButtonView extends AphrontTagView {
   private $title = null;
   private $disabled;
   private $name;
-  private $id;
-  private $sigil;
-  private $meta;
 
   public function setName($name) {
     $this->name = $name;
@@ -85,21 +82,6 @@ final class PHUIButtonView extends AphrontTagView {
     return $this;
   }
 
-  public function setID($id) {
-    $this->id = $id;
-    return $this;
-  }
-
-  public function setSigil($sigil) {
-    $this->sigil = $sigil;
-    return $this;
-  }
-
-  public function setMeta($meta) {
-    $this->meta = $meta;
-    return $this;
-  }
-
   public function getTagName() {
     return $this->tag;
   }
@@ -136,9 +118,6 @@ final class PHUIButtonView extends AphrontTagView {
       'href'   => $this->href,
       'name'   => $this->name,
       'title'  => $this->title,
-      'id'     => $this->id,
-      'sigil'  => $this->sigil,
-      'meta'   => $this->meta,
     );
   }
 

src/view/phui/PHUIObjectBoxView.php

@@ -170,7 +170,7 @@ final class PHUIObjectBoxView extends AphrontView {
       $meta = array(
         'map' => array(
           $this->actionListID => 'phabricator-action-list-toggle',
-          $icon_id => 'phui-mobile-action-menu-open',
+          $icon_id => 'phuix-dropdown-open',
         ),);
       $mobile_menu = id(new PHUIButtonView())
         ->setTag('a')
@@ -179,8 +179,8 @@ final class PHUIObjectBoxView extends AphrontView {
         ->setIcon($icon)
         ->addClass('phui-mobile-menu')
         ->setID($icon_id)
-        ->setSigil('jx-toggle-class')
+        ->addSigil('jx-toggle-class')
-        ->setMeta($meta);
+        ->setMetadata($meta);
       $header->addActionLink($mobile_menu);
     }
 

webroot/rsrc/css/phui/phui-header-view.css

@@ -146,7 +146,3 @@ body.device-phone .phui-header-view {
 .device .phui-header-action-links .phui-mobile-menu {
   display: inline-block;
 }
-
-.phui-mobile-action-menu-open {
-  background: white !important;
-}