From 9f8e0ad473a653e38c850b9314bf32fcfcc8bd23 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 25 Apr 2018 06:17:17 -0700 Subject: [PATCH] Remove unusual unicode marks in Differential action dropdown Summary: See . Currently, the action dropdown in Differential shows a heavy "X" after "Request Changes" and a heavy checkmark after "Accept Revision". Although I'm not convinced that the messaging around "Request Changes" is too strong, I do think these marks are out of place in modern Differential. They came from a simpler time when this dropdown had fewer actions, but feel a little weird and inconsistent to me in the modern UI. Let's try getting rid of them and see how it goes? Test Plan: - Viewed these actions in the dropdown, no longer saw the mark icons. - Grepped for these unicode sequences without getting any other hits. Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D19405 --- .../xaction/DifferentialRevisionAcceptTransaction.php | 2 +- .../xaction/DifferentialRevisionRejectTransaction.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php b/src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php index 81544f08ff..42cd798584 100644 --- a/src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php +++ b/src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php @@ -7,7 +7,7 @@ final class DifferentialRevisionAcceptTransaction const ACTIONKEY = 'accept'; protected function getRevisionActionLabel() { - return pht("Accept Revision \xE2\x9C\x94"); + return pht('Accept Revision'); } protected function getRevisionActionDescription( diff --git a/src/applications/differential/xaction/DifferentialRevisionRejectTransaction.php b/src/applications/differential/xaction/DifferentialRevisionRejectTransaction.php index 78f88489ff..0ed6db96bf 100644 --- a/src/applications/differential/xaction/DifferentialRevisionRejectTransaction.php +++ b/src/applications/differential/xaction/DifferentialRevisionRejectTransaction.php @@ -7,7 +7,7 @@ final class DifferentialRevisionRejectTransaction const ACTIONKEY = 'reject'; protected function getRevisionActionLabel() { - return pht("Request Changes \xE2\x9C\x98"); + return pht('Request Changes'); } protected function getRevisionActionDescription(