From 9faf413eb666650f769c2528f7bb6e0552935ecd Mon Sep 17 00:00:00 2001 From: Chad Little Date: Tue, 10 Jun 2014 13:33:38 -0700 Subject: [PATCH] Remove nowrap from PHUITagCore Summary: Removes the outer inline-block on PHUITags, it isn't needed and causes issues in some browsers, like Chrome Android. Tags also wrap again on long tags. Test Plan: tested hovercards, tags, people tags, maniphest, project tags, typeahead tags. Chrome, IE 8-11, Safari for good measure. {F164573} Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9439 --- resources/celerity/map.php | 10 +++++----- .../rsrc/css/layout/phabricator-action-header-view.css | 1 + webroot/rsrc/css/phui/phui-tag-view.css | 5 ++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 176cd29311..4d4f942332 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -7,7 +7,7 @@ return array( 'names' => array( - 'core.pkg.css' => '7a1dd133', + 'core.pkg.css' => 'd82d2f53', 'core.pkg.js' => '88ca2043', 'darkconsole.pkg.js' => 'ca8671ce', 'differential.pkg.css' => '4a93db37', @@ -111,7 +111,7 @@ return array( 'rsrc/css/font/font-awesome.css' => '73d075c3', 'rsrc/css/font/font-source-sans-pro.css' => '91d53463', 'rsrc/css/font/phui-font-icon-base.css' => 'eb84f033', - 'rsrc/css/layout/phabricator-action-header-view.css' => 'e464b159', + 'rsrc/css/layout/phabricator-action-header-view.css' => '47bc4698', 'rsrc/css/layout/phabricator-action-list-view.css' => 'dcbfc854', 'rsrc/css/layout/phabricator-crumbs-view.css' => '7fbf25b8', 'rsrc/css/layout/phabricator-filetree-view.css' => 'fccf9f82', @@ -140,7 +140,7 @@ return array( 'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b', 'rsrc/css/phui/phui-spacing.css' => '042804d6', 'rsrc/css/phui/phui-status.css' => '2f562399', - 'rsrc/css/phui/phui-tag-view.css' => '74051f4e', + 'rsrc/css/phui/phui-tag-view.css' => 'ef0a9ca8', 'rsrc/css/phui/phui-text.css' => '23e9b4b7', 'rsrc/css/phui/phui-timeline-view.css' => 'bbd990d0', 'rsrc/css/phui/phui-workboard-view.css' => '2bf82d00', @@ -683,7 +683,7 @@ return array( 'paste-css' => 'aa1767d1', 'path-typeahead' => 'f7fc67ec', 'people-profile-css' => 'ba7b2762', - 'phabricator-action-header-view-css' => 'e464b159', + 'phabricator-action-header-view-css' => '47bc4698', 'phabricator-action-list-view-css' => 'dcbfc854', 'phabricator-application-launch-view-css' => '81bebcff', 'phabricator-busy' => '6453c869', @@ -767,7 +767,7 @@ return array( 'phui-remarkup-preview-css' => '19ad512b', 'phui-spacing-css' => '042804d6', 'phui-status-list-view-css' => '2f562399', - 'phui-tag-view-css' => '74051f4e', + 'phui-tag-view-css' => 'ef0a9ca8', 'phui-text-css' => '23e9b4b7', 'phui-timeline-view-css' => 'bbd990d0', 'phui-workboard-view-css' => '2bf82d00', diff --git a/webroot/rsrc/css/layout/phabricator-action-header-view.css b/webroot/rsrc/css/layout/phabricator-action-header-view.css index 53dcc7ae2f..bc153b8dc4 100644 --- a/webroot/rsrc/css/layout/phabricator-action-header-view.css +++ b/webroot/rsrc/css/layout/phabricator-action-header-view.css @@ -42,6 +42,7 @@ .phabricator-action-header-icon-item .phui-tag-view { margin: 4px 2px 0; + display: inline-block; } .phabricator-action-header-link { diff --git a/webroot/rsrc/css/phui/phui-tag-view.css b/webroot/rsrc/css/phui/phui-tag-view.css index 4e30aca152..3a0c3519c5 100644 --- a/webroot/rsrc/css/phui/phui-tag-view.css +++ b/webroot/rsrc/css/phui/phui-tag-view.css @@ -5,8 +5,8 @@ .phui-tag-view { font-weight: bold; text-decoration: none; - display: inline-block; position: relative; + -webkit-font-smoothing: antialiased; } a.phui-tag-view:hover { @@ -27,7 +27,6 @@ a.phui-tag-view:hover { border: 1px solid transparent; border-radius: 3px; padding: 0 4px; - white-space: nowrap; } .phui-tag-type-state .phui-tag-core { @@ -65,7 +64,7 @@ a.phui-tag-view:hover { a.phui-tag-type-object, a.phui-tag-type-object:link, .phui-tag-core-closed .phui-tag-color-object { - color: #000000; + color: #000; } .phui-tag-type-person {