From 9fdeb2d8ac95bddfb918f6541ba1f0fbcd5b0c24 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Sat, 2 Dec 2017 16:11:58 -0800
Subject: [PATCH] (stable) Mark sessions as "signed all documents" when
 Legalpad has been uninstalled

See PHI238. When an install uninstalls "Legalpad", we were incorrectly failing
to mark sessions as "Signed All Required Documents" by bailing early.

Test Plan: Uninstalled Legalpad, logged in.
---
 .../base/controller/PhabricatorController.php | 28 +++++++++----------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/applications/base/controller/PhabricatorController.php b/src/applications/base/controller/PhabricatorController.php
index 0fee880378..5952a806ed 100644
--- a/src/applications/base/controller/PhabricatorController.php
+++ b/src/applications/base/controller/PhabricatorController.php
@@ -562,25 +562,25 @@ abstract class PhabricatorController extends AphrontController {
       return null;
     }
 
+    $must_sign_docs = array();
+    $sign_docs = array();
+
     $legalpad_class = 'PhabricatorLegalpadApplication';
     $legalpad_installed = PhabricatorApplication::isClassInstalledForViewer(
       $legalpad_class,
       $viewer);
-    if (!$legalpad_installed) {
-      return null;
-    }
+    if ($legalpad_installed) {
+      $sign_docs = id(new LegalpadDocumentQuery())
+        ->setViewer($viewer)
+        ->withSignatureRequired(1)
+        ->needViewerSignatures(true)
+        ->setOrder('oldest')
+        ->execute();
 
-    $sign_docs = id(new LegalpadDocumentQuery())
-      ->setViewer($viewer)
-      ->withSignatureRequired(1)
-      ->needViewerSignatures(true)
-      ->setOrder('oldest')
-      ->execute();
-
-    $must_sign_docs = array();
-    foreach ($sign_docs as $sign_doc) {
-      if (!$sign_doc->getUserSignature($viewer->getPHID())) {
-        $must_sign_docs[] = $sign_doc;
+      foreach ($sign_docs as $sign_doc) {
+        if (!$sign_doc->getUserSignature($viewer->getPHID())) {
+          $must_sign_docs[] = $sign_doc;
+        }
       }
     }