From a00e867de0941ed4b50d4bda294ccfb884a8bba5 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Wed, 19 Oct 2016 15:15:06 -0700
Subject: [PATCH] Hide footer on mobile Conpherence

Summary: This has been causing scrolling issues for me for a while, turns out the footer behind the Conpherence layout can bubble up and cause scrolling issues if you don't hit the scrollarea in the right place with your finger. Hiding it via CSS or removing the footer in the configuration resolves the issue on my phone on secure.

Test Plan: Test with and without footer on secure, hide footer in CSS since it's not visible anyways.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D16732
---
 resources/celerity/map.php                                | 6 +++---
 webroot/rsrc/css/application/conpherence/message-pane.css | 5 +++++
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 4c79d8893e..350c5c53b0 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'conpherence.pkg.css' => 'fabab894',
+    'conpherence.pkg.css' => 'cea72e09',
     'conpherence.pkg.js' => '6249a1cf',
     'core.pkg.css' => '46d588e4',
     'core.pkg.js' => '2d9fc958',
@@ -49,7 +49,7 @@ return array(
     'rsrc/css/application/conpherence/durable-column.css' => 'd82e130c',
     'rsrc/css/application/conpherence/header-pane.css' => '1c81cda6',
     'rsrc/css/application/conpherence/menu.css' => '4f51db5a',
-    'rsrc/css/application/conpherence/message-pane.css' => 'b499f371',
+    'rsrc/css/application/conpherence/message-pane.css' => '394ae8fa',
     'rsrc/css/application/conpherence/notification.css' => '965db05b',
     'rsrc/css/application/conpherence/participant-pane.css' => 'ac1baaa8',
     'rsrc/css/application/conpherence/transaction.css' => '85129c68',
@@ -619,7 +619,7 @@ return array(
     'conpherence-durable-column-view' => 'd82e130c',
     'conpherence-header-pane-css' => '1c81cda6',
     'conpherence-menu-css' => '4f51db5a',
-    'conpherence-message-pane-css' => 'b499f371',
+    'conpherence-message-pane-css' => '394ae8fa',
     'conpherence-notification-css' => '965db05b',
     'conpherence-participant-pane-css' => 'ac1baaa8',
     'conpherence-thread-manager' => '358c717b',
diff --git a/webroot/rsrc/css/application/conpherence/message-pane.css b/webroot/rsrc/css/application/conpherence/message-pane.css
index db82a4a336..6336ac0cc5 100644
--- a/webroot/rsrc/css/application/conpherence/message-pane.css
+++ b/webroot/rsrc/css/application/conpherence/message-pane.css
@@ -411,6 +411,11 @@
     margin-bottom: 0;
 }
 
+/* this causes scrolling issues on iDevices */
+.device .conpherence-layout + .phabricator-standard-page-footer {
+  display: none;
+}
+
 /***** Thread Loading *********************************************************/
 
 .conpherence-layout .conpherence-loading-mask {