From a039c4952f6b13f380e2df3a8989c856c87bb952 Mon Sep 17 00:00:00 2001
From: Andre Klapper <a9016009@gmx.de>
Date: Fri, 19 Jul 2024 13:42:28 +0200
Subject: [PATCH] Remove call to undefined method DoorkeeperDAO::getObjectKey()

Summary: Remove call to undefined static method `DoorKeeperDAO::getObjectKey()` in the `DoorkeeperExternalObject` class. `getObjectKey()` does not exist (and never existed) in any of its parent classes (`DoorkeeperDAO`, `PhabricatorLiskDAO`, `LiskDAO`).

Test Plan: Run static code analysis. Grep the source code and check the git history of parent classes.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25734
---
 .../doorkeeper/storage/DoorkeeperExternalObject.php         | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/applications/doorkeeper/storage/DoorkeeperExternalObject.php b/src/applications/doorkeeper/storage/DoorkeeperExternalObject.php
index a4ce41adac..a6d4704a90 100644
--- a/src/applications/doorkeeper/storage/DoorkeeperExternalObject.php
+++ b/src/applications/doorkeeper/storage/DoorkeeperExternalObject.php
@@ -60,11 +60,7 @@ final class DoorkeeperExternalObject extends DoorkeeperDAO
   }
 
   public function getObjectKey() {
-    $key = parent::getObjectKey();
-    if ($key === null) {
-      $key = $this->getRef()->getObjectKey();
-    }
-    return $key;
+    return $this->getRef()->getObjectKey();
   }
 
   public function getRef() {