revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 21:40:55 +01:00
Code Issues Releases Wiki Activity

Declare that revision was closed by committer, not author

Browse source 
Summary: D2703#13 is confusing - it looks like that @allenjohnashton took the action but it was @epriestley.

Test Plan: I don't have a repro so I tested this block standalone.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D2707
This commit is contained in:
vrana 2012-06-11 10:45:55 -07:00
parent dd2b027905
commit a0b57cefb7
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
View file

@ -98,10 +98,16 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
$commit_is_new = $conn_w->getAffectedRows();
$message = null;
$name = $data->getCommitDetail('committer');
if ($name !== null) {
$committer = $data->getCommitDetail('committerPHID');
} else {
$committer = $data->getCommitDetail('authorPHID');
$name = $data->getAuthorName();
}
if (!$committer) {
$committer = $revision->getAuthorPHID();
$message = 'Closed by '.$data->getAuthorName().'.';
$message = 'Closed by '.$name.'.';
}
if ($commit_is_new) {