revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00
Code Issues Releases Wiki Activity

When viewing a workboard, only link to parent workboards in crumbs if parents have workboards

Browse source 
Summary:
Depends on D20516. See PHI1247. In D20331, I made the crumbs on workboards point at ancestor workboards.

However, this isn't a great destination if an ancestor doesn't actually have a workboard. In this case, point at the normal profile URI instead.

Test Plan:
  - Viewed a milestone workboard with a parent that had no workboard. Saw a profile link instead of a workboard link (new behavior).
  - Viewed a milestone workboard with a parent that also had a workboard. Saw a workboard link (existing old behavior still works).

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20517
This commit is contained in:
epriestley 2019-05-13 07:18:58 -07:00
parent 104eefaa10
commit a1f08de283
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/project/controller/PhabricatorProjectController.php
View file

@ -109,7 +109,11 @@ abstract class PhabricatorProjectController extends PhabricatorController {
} else { } else {
switch ($mode) { switch ($mode) {
case 'workboard': case 'workboard':
if ($ancestor->getHasWorkboard()) {
$crumb_uri = $ancestor->getWorkboardURI(); $crumb_uri = $ancestor->getWorkboardURI();
} else {
$crumb_uri = $ancestor->getProfileURI();
}
break; break;
case 'profile': case 'profile':
default: default: