revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
Code Issues Releases Wiki Activity

Specify a null behavior for the callsign sort column.

Browse source 
Summary:
Fixes paging on the Diffusion Repository List.

PhabricatorRepositoryQuery needs to specify a behavior for `null` on the OderableColumns definition for the `callsign` column.

See https://phabricator.wikimedia.org/T180457

Test Plan:
1. On an instance with more than 100 repositories
 * some of which are missing a callsign
2. Attempt to sort by callsign.
3. See the sorted results

Previously:

3. Exception: "Column "0" has null value, but does not specify a null behavior."

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D18773
This commit is contained in:
Mukunda Modell 2017-11-14 17:03:16 -06:00
parent 95a5b41b0b
commit a1f12b4ac7
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/repository/query/PhabricatorRepositoryQuery.php
View file

@ -425,6 +425,7 @@ final class PhabricatorRepositoryQuery
'type' => 'string', 'type' => 'string',
'unique' => true, 'unique' => true,
'reverse' => true, 'reverse' => true,
'null' => 'tail',
), ),
'name' => array( 'name' => array(
'table' => 'r', 'table' => 'r',