revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-04-02 07:28:17 +02:00
Code Issues Releases Wiki Activity

When "phabricator.silent" is enabled, don't call webhooks

Browse source 
Summary: Ref T13078. The `phabricator.silent` configuration flag should disable webhook calls, since this is consistent with the documented and desired behavior.

Test Plan: Enabled `phabricator.silent`, made test hook calls, saw them fail with a "silent" failure reason.

Maniphest Tasks: T13078

Differential Revision: https://secure.phabricator.com/D19084
This commit is contained in:
epriestley 2018-02-14 11:09:57 -08:00
parent 6bfd0ff275
commit a2453706ab
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/herald/worker/HeraldWebhookWorker.php
View file

@ -32,6 +32,13 @@ final class HeraldWebhookWorker
$status)); $status));
} }
// If we're in silent mode, permanently fail the webhook request and then
// return to complete this task.
if (PhabricatorEnv::getEnvConfig('phabricator.silent')) {
$this->failRequest($request, 'hook', 'silent');
return;
}
$hook = $request->getWebhook(); $hook = $request->getWebhook();
if ($hook->isDisabled()) { if ($hook->isDisabled()) {