1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00

Remove obsolete/deprecated withTaskIDs() / withTaskPHIDs()

Summary: Ref T603. These were deprecated some time ago in favor of the more standard withIDs() / withPHIDs().

Test Plan: `grep`, loaded some interfaces.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D6929
This commit is contained in:
epriestley 2013-09-10 07:47:55 -07:00
parent e625c91867
commit a2571de575
6 changed files with 6 additions and 18 deletions

View file

@ -228,7 +228,7 @@ abstract class DifferentialFreeformFieldSpecification
$tasks = id(new ManiphestTaskQuery())
->setViewer($user)
->withTaskIDs(array_keys($tasks_statuses))
->withIDs(array_keys($tasks_statuses))
->execute();
foreach ($tasks as $task_id => $task) {

View file

@ -85,18 +85,6 @@ final class ManiphestTaskQuery extends PhabricatorQuery {
return $this;
}
// TODO: Deprecated in favor of `withIDs()`.
public function withTaskIDs(array $ids) {
$this->taskIDs = $ids;
return $this;
}
// TODO: Deprecated in favor of `withPHIDs()`.
public function withTaskPHIDs(array $phids) {
$this->taskPHIDs = $phids;
return $this;
}
public function withOwners(array $owners) {
$this->includeUnowned = false;
foreach ($owners as $k => $phid) {

View file

@ -69,12 +69,12 @@ class ConduitAPI_maniphest_query_Method
$task_ids = $request->getValue('ids');
if ($task_ids) {
$query->withTaskIDs($task_ids);
$query->withIDs($task_ids);
}
$task_phids = $request->getValue('phids');
if ($task_phids) {
$query->withTaskPHIDs($task_phids);
$query->withPHIDs($task_phids);
}
$owners = $request->getValue('ownerPHIDs');

View file

@ -460,7 +460,7 @@ final class ManiphestTaskListController extends ManiphestController {
$query = new ManiphestTaskQuery();
$query->setViewer($viewer);
$query->withTaskIDs($task_ids);
$query->withIDs($task_ids);
if ($project_phids) {
$query->withAllProjects($project_phids);

View file

@ -16,7 +16,7 @@ final class ManiphestTaskMailReceiver extends PhabricatorObjectMailReceiver {
$results = id(new ManiphestTaskQuery())
->setViewer($viewer)
->withTaskIDs(array($id))
->withIDs(array($id))
->execute();
return head($results);

View file

@ -15,7 +15,7 @@ final class ManiphestRemarkupRule
return id(new ManiphestTaskQuery())
->setViewer($viewer)
->withTaskIDs($ids)
->withIDs($ids)
->execute();
}