From a2cd3d9a8913d5709e2bc999efb75b63d7c19696 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 12 Jan 2017 15:11:05 -0800
Subject: [PATCH] Change PHP 7 setup warning to complain about 7.0 only, not
 7.1+

Summary: Ref T9640. On 7.0 we had signal handling issues so we can never support it, but async signals should resolve them on 7.1 or newer.

Test Plan: On PHP 7.1, got through the setup warning.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9640

Differential Revision: https://secure.phabricator.com/D17197
---
 .../config/check/PhabricatorPHPPreflightSetupCheck.php   | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php b/src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php
index 82a13438d8..7c9653f4ff 100644
--- a/src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php
+++ b/src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php
@@ -11,15 +11,16 @@ final class PhabricatorPHPPreflightSetupCheck extends PhabricatorSetupCheck {
   }
 
   protected function executeChecks() {
-    if (version_compare(phpversion(), 7, '>=')) {
+    if (version_compare(phpversion(), 7, '>=') &&
+        version_compare(phpversion(), 7.1, '<')) {
       $message = pht(
-        'This version of Phabricator does not support PHP 7. You '.
-        'are running PHP %s.',
+        'This version of Phabricator does not support PHP 7.0. You '.
+        'are running PHP %s. Upgrade to PHP 7.1 or newer.',
         phpversion());
 
       $this->newIssue('php.version7')
         ->setIsFatal(true)
-        ->setName(pht('PHP 7 Not Supported'))
+        ->setName(pht('PHP 7.0 Not Supported'))
         ->setMessage($message)
         ->addLink(
           'https://phurl.io/u/php7',