revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 16:22:43 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exception which blocks editing a Dashboard Tab Panel

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15345

Test Plan: After applying this change, the "Edit Panel" page at `/dashboard/panel/edit/2/` correctly rendered in the web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15345

Differential Revision: https://we.phorge.it/D25189
This commit is contained in:
Andre Klapper 2023-05-05 14:53:26 +02:00
parent f4d28119e8
commit a3861edc19
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/dashboard/controller/panel/PhabricatorDashboardPanelEditController.php
View file

@ -15,7 +15,7 @@ final class PhabricatorDashboardPanelEditController
// editing. // editing.
$context_phid = $request->getStr('contextPHID'); $context_phid = $request->getStr('contextPHID');
if (strlen($context_phid)) { if (phutil_nonempty_string($context_phid)) {
$context = id(new PhabricatorObjectQuery()) $context = id(new PhabricatorObjectQuery())
->setViewer($viewer) ->setViewer($viewer)
->withPHIDs(array($context_phid)) ->withPHIDs(array($context_phid))