mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-22 23:02:42 +01:00
Remove pointless requireCapabilities() method from PhabricatorProjectColumnTransactionEditor
Summary: Depends on D19581. Ref T13164. This method has no effect: - You must always have CAN_EDIT to reach an Editor in the first place. - Per previous change, I'm going to restructure this so transactions explicitly check CAN_EDIT by default anyway. Test Plan: Tried to edit and hide a project column as a user without permission, hit global permission checks long before reaching this method. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13164 Differential Revision: https://secure.phabricator.com/D19582
This commit is contained in:
parent
296bf046a8
commit
a39852ae1b
1 changed files with 0 additions and 18 deletions
|
@ -137,22 +137,4 @@ final class PhabricatorProjectColumnTransactionEditor
|
||||||
return $errors;
|
return $errors;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
protected function requireCapabilities(
|
|
||||||
PhabricatorLiskDAO $object,
|
|
||||||
PhabricatorApplicationTransaction $xaction) {
|
|
||||||
|
|
||||||
switch ($xaction->getTransactionType()) {
|
|
||||||
case PhabricatorProjectColumnTransaction::TYPE_NAME:
|
|
||||||
case PhabricatorProjectColumnTransaction::TYPE_STATUS:
|
|
||||||
PhabricatorPolicyFilter::requireCapability(
|
|
||||||
$this->requireActor(),
|
|
||||||
$object,
|
|
||||||
PhabricatorPolicyCapability::CAN_EDIT);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
return parent::requireCapabilities($object, $xaction);
|
|
||||||
}
|
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue