1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-30 01:10:58 +01:00

Make setup check groups more robust against fataling existing subclasses

Auditors: chad
This commit is contained in:
epriestley 2015-02-10 16:53:38 -08:00
parent bdd7a35b30
commit a3f380a695

View file

@ -19,7 +19,10 @@ abstract class PhabricatorSetupCheck {
$issue = id(new PhabricatorSetupIssue())
->setIssueKey($key);
$this->issues[$key] = $issue;
$issue->setGroup($this->getDefaultGroup());
if ($this->getDefaultGroup()) {
$issue->setGroup($this->getDefaultGroup());
}
return $issue;
}
@ -28,6 +31,10 @@ abstract class PhabricatorSetupCheck {
return $this->issues;
}
public function getDefaultGroup() {
return null;
}
final public function runSetupChecks() {
$this->issues = array();
$this->executeChecks();