revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-29 07:58:19 +01:00
Code Issues Releases Wiki Activity

Make setup check groups more robust against fataling existing subclasses

Browse source 
Auditors: chad
This commit is contained in:
epriestley 2015-02-10 16:53:38 -08:00
parent bdd7a35b30
commit a3f380a695
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/config/check/PhabricatorSetupCheck.php
View file

@ -19,7 +19,10 @@ abstract class PhabricatorSetupCheck {
$issue = id(new PhabricatorSetupIssue()) $issue = id(new PhabricatorSetupIssue())
->setIssueKey($key); ->setIssueKey($key);
$this->issues[$key] = $issue; $this->issues[$key] = $issue;
if ($this->getDefaultGroup()) {
$issue->setGroup($this->getDefaultGroup()); $issue->setGroup($this->getDefaultGroup());
}
return $issue; return $issue;
} }
@ -28,6 +31,10 @@ abstract class PhabricatorSetupCheck {
return $this->issues; return $this->issues;
} }
public function getDefaultGroup() {
return null;
}
final public function runSetupChecks() { final public function runSetupChecks() {
$this->issues = array(); $this->issues = array();
$this->executeChecks(); $this->executeChecks();