revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Correct rendering of workboard column move stories when a single transaction performs moves on multiple boards

Browse source 
Summary:
See <https://discourse.phabricator-community.org/t/unhandled-exception-rendering-maniphest-task/3234>.

If a single transaction performs column moves on multiple different boards (which is permitted in the API), the rendering logic currently fails. Make it render properly.

Test Plan: {F7011464}

Differential Revision: https://secure.phabricator.com/D20901
This commit is contained in:
epriestley 2019-11-08 16:53:11 -08:00
parent b83b3224bb
commit a3f4cbd748
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
View file

@ -1133,6 +1133,8 @@ abstract class PhabricatorApplicationTransaction
} else { } else {
$fragments = array(); $fragments = array();
foreach ($moves as $move) { foreach ($moves as $move) {
$to_column = $move['columnPHID'];
$board_phid = $move['boardPHID'];
$fragments[] = pht( $fragments[] = pht(
'%s (%s)', '%s (%s)',
$this->renderHandleLink($board_phid), $this->renderHandleLink($board_phid),